Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(580)

Issue 604813003: Remove SkPaint dirty bits. (Closed)

Created:
6 years, 2 months ago by mtklein_C
Modified:
6 years, 2 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Remove SkPaint dirty bits. fDirtyBits is only used by SkPaint::FlatteningTraits, which in turn was only used as a smaller, faster format to flatten paints in-memory to dedup them in the old picture backend. SkRecord obsoleted all this. Neither flatten()/unflatten() (disk format) nor FlatteningTraits is used anywhere performance or size matters. Here I revert the deduping code back to using the disk format for flattened paints. We stil do have to flatten and unflatten paints while coverting from SkRecord backend to the old backend, so we can't just delete this all yet, but any faithful round trip flatten()/unflatten() pair will be fine, however slow. NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/610a015fda84cd5d1e3f3f826bab393f1193bc0e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -150 lines) Patch
M include/core/SkPaint.h View 2 chunks +0 lines, -6 lines 0 comments Download
M src/core/SkPaint.cpp View 14 chunks +1 line, -127 lines 0 comments Download
M src/core/SkPictureData.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/core/SkPictureFlat.h View 2 chunks +7 lines, -2 lines 0 comments Download
M tests/PaintTest.cpp View 2 chunks +4 lines, -13 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
mtklein
6 years, 2 months ago (2014-09-25 18:05:51 UTC) #2
reed1
The diff is nearly all RED -- (i.e. deletions) lgtm
6 years, 2 months ago (2014-09-25 18:36:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/604813003/1
6 years, 2 months ago (2014-09-25 18:48:17 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-VS2013-x86-Debug-Trybot on tryserver.skia (http://108.170.220.76:10117/builders/Build-Win-VS2013-x86-Debug-Trybot/builds/1954)
6 years, 2 months ago (2014-09-25 18:52:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/604813003/1
6 years, 2 months ago (2014-09-25 18:57:45 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-09-25 18:57:57 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 610a015fda84cd5d1e3f3f826bab393f1193bc0e

Powered by Google App Engine
This is Rietveld 408576698