Custom Element should have a wrapper while frame navigation

Custom Element should have a wrapper while frame navigation

When frame navigation occurs, the script context containing
the custom element is destroyed. And, hence we were hitting
an early written.
This patch allocates the wrapper in whatever context the other
wrappers are being allocated in.

BUG=323430
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183064

[deepak.sa, 2014-09-25 14:06:46]

deepak.sa@samsung.com changed reviewers:
+ dominicc@chromium.org, esprehn@chromium.org

[deepak.sa, 2014-09-25 14:06:47]

PTAL?
Thanks!

[dominicc (has gone to gerrit), 2014-09-26 08:07:02]

There's a typo in your description--early written/early return.

I don't understand this test, unfortunately. Can it be simplified? For example:

Your description is about the wrapper of the element in the iframe. But you have
a Custom Element with the same type name in the main frame too. Why?

Your description is about navigating the iframe, but you clone the element using
innerHTML into the main frame. Wouldn't it be sufficient to test the value
directly?

I suspect either (a) I don't understand it, or (b) the test can be made much,
much simpler.

As for the change, I need to stare at this more. Having a simpler test would
help.

https://codereview.chromium.org/604773002/diff/20001/LayoutTests/fast/dom/cus...
File LayoutTests/fast/dom/custom/prerender-insert-after-stop.html (right):

https://codereview.chromium.org/604773002/diff/20001/LayoutTests/fast/dom/cus...
LayoutTests/fast/dom/custom/prerender-insert-after-stop.html:12:
document.getElementById("log").innerHTML = customBody;
Be consistent about using single quotes for string literals. Below too.

[deepak.sa, 2014-09-29 06:10:54]

On 2014/09/26 08:07:02, dominicc wrote:
> There's a typo in your description--early written/early return.
> 
> I don't understand this test, unfortunately. Can it be simplified? For
example:
> 
> Your description is about the wrapper of the element in the iframe. But you
have
> a Custom Element with the same type name in the main frame too. Why?
> 
> Your description is about navigating the iframe, but you clone the element
using
> innerHTML into the main frame. Wouldn't it be sufficient to test the value
> directly?
> 
> I suspect either (a) I don't understand it, or (b) the test can be made much,
> much simpler.
> 
> As for the change, I need to stare at this more. Having a simpler test would
> help.
> 
>
https://codereview.chromium.org/604773002/diff/20001/LayoutTests/fast/dom/cus...
> File LayoutTests/fast/dom/custom/prerender-insert-after-stop.html (right):
> 
>
https://codereview.chromium.org/604773002/diff/20001/LayoutTests/fast/dom/cus...
> LayoutTests/fast/dom/custom/prerender-insert-after-stop.html:12:
> document.getElementById("log").innerHTML = customBody;
> Be consistent about using single quotes for string literals. Below too.

Sorry for the confusing test. I just picked the test case given in the bug.
I'll try to make it simpler.

[deepak.sa, 2014-09-29 12:58:10]

I have uploaded a new patch.
PTAL?
Thanks!

https://codereview.chromium.org/604773002/diff/20001/LayoutTests/fast/dom/cus...
File LayoutTests/fast/dom/custom/prerender-insert-after-stop.html (right):

https://codereview.chromium.org/604773002/diff/20001/LayoutTests/fast/dom/cus...
LayoutTests/fast/dom/custom/prerender-insert-after-stop.html:12:
document.getElementById("log").innerHTML = customBody;
On 2014/09/26 08:07:02, dominicc wrote:
> Be consistent about using single quotes for string literals. Below too.

Done.

[dominicc (has gone to gerrit), 2014-10-01 14:07:16]

The CQ bit was checked by dominicc@chromium.org

[dominicc (has gone to gerrit), 2014-10-01 14:07:17]

lgtm

[commit-bot: I haz the power, 2014-10-01 14:08:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/604773002/40001

[commit-bot: I haz the power, 2014-10-01 14:55:22]

Committed patchset #3 (id:40001) as 183064