Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Issue 604753002: Apply automatic range checks to enum types across IPC in content. (Closed)

Created:
6 years, 2 months ago by ARUNKK
Modified:
6 years, 2 months ago
Reviewers:
palmer, piman, dcheng, inferno
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Apply automatic range checks to enum types across IPC in content. This is part of a long-running background task to remove the remaining uses of the unchecked IPC_ENUM_TRAITS() macro. BUG=246708 Committed: https://crrev.com/a1db15d3950d911c9cfe448debdb95fc0bae0f0b Cr-Commit-Position: refs/heads/master@{#296868}

Patch Set 1 #

Patch Set 2 : . #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M content/common/view_messages.h View 1 chunk +4 lines, -2 lines 0 comments Download
M content/public/common/stop_find_action.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M content/public/common/three_d_api_types.h View 1 1 chunk +3 lines, -1 line 1 comment Download

Messages

Total messages: 19 (7 generated)
ARUNKK
dcheng@chromium.org: Please review changes in piman@chromium.org: Please review changes in PTAL.
6 years, 2 months ago (2014-09-25 10:41:12 UTC) #2
dcheng
IPC changes LGTM.
6 years, 2 months ago (2014-09-25 11:16:08 UTC) #3
ARUNKK
On 2014/09/25 11:16:08, dcheng wrote: > IPC changes LGTM. Thanks for LGTM.
6 years, 2 months ago (2014-09-25 11:17:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/604753002/20001
6 years, 2 months ago (2014-09-25 11:17:57 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/13440)
6 years, 2 months ago (2014-09-25 11:25:57 UTC) #8
ARUNKK
On 2014/09/25 11:25:57, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years, 2 months ago (2014-09-25 13:46:04 UTC) #10
piman
lgtm
6 years, 2 months ago (2014-09-25 17:58:21 UTC) #11
palmer
lgtm https://codereview.chromium.org/604753002/diff/20001/content/public/common/three_d_api_types.h File content/public/common/three_d_api_types.h (right): https://codereview.chromium.org/604753002/diff/20001/content/public/common/three_d_api_types.h#newcode18 content/public/common/three_d_api_types.h:18: Nit: No blank line here.
6 years, 2 months ago (2014-09-25 18:52:59 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/604753002/20001
6 years, 2 months ago (2014-09-26 02:57:05 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/604753002/20001
6 years, 2 months ago (2014-09-26 02:59:07 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001) as c63d3f659e135973962f46be60eb2fb7f3bf3bf8
6 years, 2 months ago (2014-09-26 03:01:16 UTC) #18
commit-bot: I haz the power
6 years, 2 months ago (2014-09-26 03:01:47 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a1db15d3950d911c9cfe448debdb95fc0bae0f0b
Cr-Commit-Position: refs/heads/master@{#296868}

Powered by Google App Engine
This is Rietveld 408576698