Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Unified Diff: tools/telemetry/telemetry/page/page_runner.py

Issue 60473002: Changed logging of expected failures from warning to info (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Updated to only affect tests with expectations Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/page/page_runner.py
diff --git a/tools/telemetry/telemetry/page/page_runner.py b/tools/telemetry/telemetry/page/page_runner.py
index 215c3babfb4b7a2a94371031d875aa27de5e6108..feb0577ff5841611304a648ab04e4d0d82073431 100644
--- a/tools/telemetry/telemetry/page/page_runner.py
+++ b/tools/telemetry/telemetry/page/page_runner.py
@@ -423,7 +423,7 @@ def _CheckArchives(page_set, pages, results):
def _RunPage(test, page, state, expectation, results, finder_options):
if expectation == 'skip':
- logging.warning('Skipped %s' % page.url)
+ logging.info('Skipped %s' % page.url)
return
logging.info('Running %s' % page.url)
@@ -446,11 +446,12 @@ def _RunPage(test, page, state, expectation, results, finder_options):
test.Run(finder_options, page, page_state.tab, results)
util.CloseConnections(page_state.tab)
except page_test.Failure:
- logging.warning('%s:\n%s', page.url, traceback.format_exc())
if expectation == 'fail':
+ logging.info('%s:\n%s', page.url, traceback.format_exc())
logging.info('Failure was expected\n')
results.AddSuccess(page)
else:
+ logging.warning('%s:\n%s', page.url, traceback.format_exc())
results.AddFailure(page, sys.exc_info())
except (util.TimeoutException, exceptions.LoginException,
exceptions.ProfilingException):
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698