Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(567)

Issue 604583002: Fix race in HostSharedBitmapManager::AllocatedBitmapCount (Closed)

Created:
6 years, 3 months ago by jbauman
Modified:
6 years, 3 months ago
Reviewers:
piman
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix race in HostSharedBitmapManager::AllocatedBitmapCount This race should be benign, because the count is just used for a heuristic and can't truly be synchronized anyway, but best to use a lock with the access. BUG=417194 Committed: https://crrev.com/b86d19a65aa6e002f7421a724f5fe29f62a016ae Cr-Commit-Position: refs/heads/master@{#296554}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M content/common/host_shared_bitmap_manager.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/common/host_shared_bitmap_manager.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jbauman
6 years, 3 months ago (2014-09-24 21:09:20 UTC) #2
piman
lgtm
6 years, 3 months ago (2014-09-24 21:55:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/604583002/1
6 years, 3 months ago (2014-09-24 21:57:09 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 497095694a5024680e7b8c89b3d3049d99a5f2c3
6 years, 3 months ago (2014-09-24 23:07:03 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-24 23:07:38 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b86d19a65aa6e002f7421a724f5fe29f62a016ae
Cr-Commit-Position: refs/heads/master@{#296554}

Powered by Google App Engine
This is Rietveld 408576698