Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 604503002: Update chrome/OWNERS android rule to match chrome/android/OWNERS. (Closed)

Created:
6 years, 3 months ago by mlamouri (slow - plz ping)
Modified:
6 years, 3 months ago
Reviewers:
Nico
CC:
chromium-reviews, Miguel Garcia
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Update chrome/OWNERS android rule to match chrome/android/OWNERS. This is also fixing the chrome/OWNERS android related rules to apply on chrome_android*.gypi files instead of *android*. BUG=None Committed: https://crrev.com/ebf1d277800088a1413ecf6e170fc9634dba95d4 Cr-Commit-Position: refs/heads/master@{#296517}

Patch Set 1 #

Patch Set 2 : review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M chrome/OWNERS View 1 1 chunk +7 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (2 generated)
mlamouri (slow - plz ping)
6 years, 3 months ago (2014-09-24 19:51:44 UTC) #2
Nico
I don't think there's any mystery why this happens, *android* just matches everything below android. ...
6 years, 3 months ago (2014-09-24 19:54:29 UTC) #3
Nico
(i didn't intentionally cc miguelg)
6 years, 3 months ago (2014-09-24 19:55:06 UTC) #4
mlamouri (slow - plz ping)
Nico, miguelg@ is owning chrome/android/ as you can see here: https://codereview.chromium.org/289283009 I think bulach@ forgot ...
6 years, 3 months ago (2014-09-24 20:01:09 UTC) #5
Nico
On 2014/09/24 20:01:09, Mounir Lamouri wrote: > Nico, miguelg@ is owning chrome/android/ as you can ...
6 years, 3 months ago (2014-09-24 20:10:24 UTC) #6
mlamouri (slow - plz ping)
Updated. PTAL.
6 years, 3 months ago (2014-09-24 20:17:00 UTC) #7
Nico
lgtm, thanks! (i would've kept the start of the glob as it was, but doesn't ...
6 years, 3 months ago (2014-09-24 20:24:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/604503002/20001
6 years, 3 months ago (2014-09-24 20:25:44 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 5a6c7b7540221e98a8ae7fa6b44fe29e13fd1561
6 years, 3 months ago (2014-09-24 21:07:20 UTC) #11
commit-bot: I haz the power
6 years, 3 months ago (2014-09-24 21:08:14 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ebf1d277800088a1413ecf6e170fc9634dba95d4
Cr-Commit-Position: refs/heads/master@{#296517}

Powered by Google App Engine
This is Rietveld 408576698