content/browser/device_sensors/sensor_manager_android_unittest.cc - Issue 604483003: Increase device orientation event frequency to 60 Hz. Change constants

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/device_sensors/sensor_manager_android_unittest.cc

Issue 604483003: Increase device orientation event frequency to 60 Hz. Change constants (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/device_sensors/sensor_manager_android.cc ('K') | « content/browser/device_sensors/sensor_manager_android.cc ('k') | content/public/android/java/src/org/chromium/content/browser/DeviceSensors.java » ('j') | content/public/android/java/src/org/chromium/content/browser/DeviceSensors.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/device_sensors/sensor_manager_android_unittest.cc

diff --git a/content/browser/device_sensors/sensor_manager_android_unittest.cc b/content/browser/device_sensors/sensor_manager_android_unittest.cc

index 560f3142bae72aa4e7a4d12dcd3d44a2ee46e5bb..096f3ecc4ae322a93cc1a0d96a70ddb2e097ef73 100644

--- a/content/browser/device_sensors/sensor_manager_android_unittest.cc

+++ b/content/browser/device_sensors/sensor_manager_android_unittest.cc

@@ -86,7 +86,8 @@ TEST_F(AndroidSensorManagerTest, ThreeDeviceMotionSensorsActive) {

ASSERT_TRUE(motion_buffer_->data.hasRotationRateBeta);

ASSERT_EQ(9, motion_buffer_->data.rotationRateGamma);

ASSERT_TRUE(motion_buffer_->data.hasRotationRateGamma);

- ASSERT_EQ(kInertialSensorIntervalMillis, motion_buffer_->data.interval);

+ ASSERT_EQ(kInertialSensorIntervalMicroseconds / 1000.,

+ motion_buffer_->data.interval);

sensorManager.StopFetchingDeviceMotionData();

ASSERT_FALSE(motion_buffer_->data.allAvailableSensorsAreActive);

@@ -105,7 +106,8 @@ TEST_F(AndroidSensorManagerTest, TwoDeviceMotionSensorsActive) {

sensorManager.GotAccelerationIncludingGravity(0, 0, 1, 2, 3);

ASSERT_TRUE(motion_buffer_->data.allAvailableSensorsAreActive);

- ASSERT_EQ(kInertialSensorIntervalMillis, motion_buffer_->data.interval);

+ ASSERT_EQ(kInertialSensorIntervalMicroseconds / 1000.,

+ motion_buffer_->data.interval);

sensorManager.StopFetchingDeviceMotionData();

ASSERT_FALSE(motion_buffer_->data.allAvailableSensorsAreActive);

@@ -118,7 +120,8 @@ TEST_F(AndroidSensorManagerTest, ZeroDeviceMotionSensorsActive) {

sensorManager.StartFetchingDeviceMotionData(motion_buffer_.get());

ASSERT_TRUE(motion_buffer_->data.allAvailableSensorsAreActive);

- ASSERT_EQ(kInertialSensorIntervalMillis, motion_buffer_->data.interval);

+ ASSERT_EQ(kInertialSensorIntervalMicroseconds / 1000.,

+ motion_buffer_->data.interval);

sensorManager.StopFetchingDeviceMotionData();

ASSERT_FALSE(motion_buffer_->data.allAvailableSensorsAreActive);