content/browser/device_sensors/data_fetcher_shared_memory_base_unittest.cc - Issue 604483003: Increase device orientation event frequency to 60 Hz. Change constants

Unified Diff: content/browser/device_sensors/data_fetcher_shared_memory_base_unittest.cc

Issue 604483003: Increase device orientation event frequency to 60 Hz. Change constants (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/device_sensors/data_fetcher_shared_memory_base.cc ('k') | content/browser/device_sensors/inertial_sensor_consts.h » ('j') | content/browser/device_sensors/inertial_sensor_consts.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/device_sensors/data_fetcher_shared_memory_base_unittest.cc

diff --git a/content/browser/device_sensors/data_fetcher_shared_memory_base_unittest.cc b/content/browser/device_sensors/data_fetcher_shared_memory_base_unittest.cc

index 1b62abab137ada058178e45301d81331c5179df0..18f419fb26bee8334e6847c774f8d9965703816c 100644

--- a/content/browser/device_sensors/data_fetcher_shared_memory_base_unittest.cc

+++ b/content/browser/device_sensors/data_fetcher_shared_memory_base_unittest.cc

@@ -67,7 +67,7 @@ class FakeDataFetcher : public DataFetcherSharedMemoryBase {

DeviceMotionHardwareBuffer* buffer = GetMotionBuffer();

ASSERT_TRUE(buffer);

buffer->seqlock.WriteBegin();

- buffer->data.interval = kInertialSensorIntervalMillis;

+ buffer->data.interval = kInertialSensorIntervalMicroseconds / 1000.;

buffer->seqlock.WriteEnd();

updated_motion_.Signal();

}

@@ -343,8 +343,8 @@ TEST(DataFetcherSharedMemoryBaseTest, DoesStartMotion) {

EXPECT_TRUE(fake_data_fetcher.StartFetchingDeviceData(CONSUMER_TYPE_MOTION));

fake_data_fetcher.WaitForStart(CONSUMER_TYPE_MOTION);

- EXPECT_EQ(kInertialSensorIntervalMillis,

- fake_data_fetcher.GetMotionBuffer()->data.interval);

+ EXPECT_EQ(kInertialSensorIntervalMicroseconds / 1000.,

+ fake_data_fetcher.GetMotionBuffer()->data.interval);

fake_data_fetcher.StopFetchingDeviceData(CONSUMER_TYPE_MOTION);

fake_data_fetcher.WaitForStop(CONSUMER_TYPE_MOTION);

@@ -388,8 +388,8 @@ TEST(DataFetcherSharedMemoryBaseTest, DoesPollMotion) {

fake_data_fetcher.WaitForStart(CONSUMER_TYPE_MOTION);

fake_data_fetcher.WaitForUpdate(CONSUMER_TYPE_MOTION);

- EXPECT_EQ(kInertialSensorIntervalMillis,

- fake_data_fetcher.GetMotionBuffer()->data.interval);

+ EXPECT_EQ(kInertialSensorIntervalMicroseconds / 1000.,

+ fake_data_fetcher.GetMotionBuffer()->data.interval);

fake_data_fetcher.StopFetchingDeviceData(CONSUMER_TYPE_MOTION);

fake_data_fetcher.WaitForStop(CONSUMER_TYPE_MOTION);

@@ -452,8 +452,8 @@ TEST(DataFetcherSharedMemoryBaseTest, DoesPollMotionAndOrientation) {

fake_data_fetcher.WaitForUpdate(CONSUMER_TYPE_MOTION);

EXPECT_EQ(1, fake_data_fetcher.GetOrientationBuffer()->data.alpha);

- EXPECT_EQ(kInertialSensorIntervalMillis,

- fake_data_fetcher.GetMotionBuffer()->data.interval);

+ EXPECT_EQ(kInertialSensorIntervalMicroseconds / 1000.,

+ fake_data_fetcher.GetMotionBuffer()->data.interval);

fake_data_fetcher.StopFetchingDeviceData(CONSUMER_TYPE_ORIENTATION);

fake_data_fetcher.StopFetchingDeviceData(CONSUMER_TYPE_MOTION);