Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(616)

Unified Diff: content/browser/device_sensors/inertial_sensor_consts.h

Issue 604483003: Increase device orientation event frequency to 60 Hz. Change constants (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: sync Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/device_sensors/inertial_sensor_consts.h
diff --git a/content/browser/device_sensors/inertial_sensor_consts.h b/content/browser/device_sensors/inertial_sensor_consts.h
index da099ad0c0070889e2f84f8473a95507fa11a7f2..1f665bdbb5d69c94436636a63ba6d7ff55ad3218 100644
--- a/content/browser/device_sensors/inertial_sensor_consts.h
+++ b/content/browser/device_sensors/inertial_sensor_consts.h
@@ -5,6 +5,8 @@
#ifndef CONTENT_BROWSER_DEVICE_SENSORS_INERTIAL_SENSOR_CONSTS_H_
#define CONTENT_BROWSER_DEVICE_SENSORS_INERTIAL_SENSOR_CONSTS_H_
+#include "base/time/time.h"
+
namespace content {
// Constants related to the Device {Motion|Orientation|Light} APIs.
@@ -15,14 +17,19 @@ enum ConsumerType {
CONSUMER_TYPE_LIGHT = 1 << 2,
};
-// Specifies the minimal interval between subsequent sensor data updates.
+// Specifies the sampling rate for sensor data updates.
// Note that when changing this value it is desirable to have an adequate
-// matching value |DeviceSensorEventPump::kDefaultPumpDelayMillis| in
-// content/renderer/device_sensors/device_sensor_event_pump.cc.
-const int kInertialSensorIntervalMillis = 50;
-// Corresponding |kDefaultLightPumpDelayMillis| is in
+// matching value |DeviceSensorEventPump::kDefaultPumpFrequencyHz| in
+// content/renderer/device_orientation/device_sensor_event_pump.cc.
+const int kInertialSensorSamplingRateHz = 60;
+const int kInertialSensorIntervalMicroseconds =
+ base::Time::kMicrosecondsPerSecond / kInertialSensorSamplingRateHz;
+
+// Corresponding |kDefaultLightPumpFrequencyHz| is in
// content/renderer/device_sensors/device_light_event_pump.cc.
-const int kLightSensorIntervalMillis = 200;
+const int kLightSensorSamplingRateHz = 5;
+const int kLightSensorIntervalMicroseconds =
+ base::Time::kMicrosecondsPerSecond / kLightSensorSamplingRateHz;
} // namespace content

Powered by Google App Engine
This is Rietveld 408576698