Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 604483002: NaCl: Update revision in DEPS, r13759 -> r13770 (Closed)

Created:
6 years, 3 months ago by Mark Seaborn
Modified:
6 years, 2 months ago
Reviewers:
Derek Schuff, sergeyv
CC:
chromium-reviews, dbrazdil, Derek Schuff, David Yen, native-client-reviews_googlegroups.com, teravest
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

NaCl: Update revision in DEPS, r13759 -> r13770 This pulls in the following Native Client changes: r13760: (mseaborn) untrusted.gypi: Factor out duplicated "--gomadir" option r13761: (mseaborn) Fix mmap() with length > 0xffff0000 to behave consistently on 32/64-bit r13762: (teravest) Support file path metadata for the main nexe. r13763: (teravest) Add CreateNaClDescWithFilePathMetadata fn. r13764: (dschuff) Switch PNaCl lib, include, and translator directories for new layout r13765: (dschuff) Pass naclsdk_validate=0 to scons runs run by main waterfall bots r13768: (dbrazdil) Allowed decrementing program break with sbrk() in MinSFI r13769: (dyen) Added tests for rename functions in irt_ext. r13770: (dyen) Added tests for unlink functions irt_ext. BUG=none TEST=browser_tests and nacl_integration CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_rel_precise32,linux_nacl_sdk,linux_chromium_dbg TBR=dschuff@chromium.org Committed: https://crrev.com/a86ea9cb2d97183ae3080b7325bdc23e392ce96c Cr-Commit-Position: refs/heads/master@{#296654}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (5 generated)
Mark Seaborn
I'm rolling to before NaCl revision r13771, since that change breaks the compile.
6 years, 3 months ago (2014-09-24 20:02:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/604483002/1
6 years, 3 months ago (2014-09-24 20:03:27 UTC) #4
Derek Schuff
lgtm
6 years, 3 months ago (2014-09-24 20:26:10 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_arm_cross_compile on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_arm_cross_compile/builds/83)
6 years, 3 months ago (2014-09-25 05:20:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/604483002/1
6 years, 3 months ago (2014-09-25 05:33:52 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as de58c3cbc61847f1533cfd7cec8af7a530bb9e72
6 years, 3 months ago (2014-09-25 05:34:42 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a86ea9cb2d97183ae3080b7325bdc23e392ce96c Cr-Commit-Position: refs/heads/master@{#296654}
6 years, 3 months ago (2014-09-25 05:35:10 UTC) #11
sergeyv
After this roll, GYP_GENERATORS=ninja ./build/gyp_chromium fails in configuration with enabled goma ('use_goma': '1' in include.gypi): ...
6 years, 2 months ago (2014-09-25 12:12:31 UTC) #13
Mathieu
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/605743002/ by mathp@chromium.org. ...
6 years, 2 months ago (2014-09-25 13:30:08 UTC) #14
Mark Seaborn
6 years, 2 months ago (2014-09-25 16:48:53 UTC) #15
Message was sent while issue was closed.
On 2014/09/25 13:30:08, Mathieu Perreault wrote:
> A revert of this CL (patchset #1 id:1) has been created in
> https://codereview.chromium.org/605743002/ by mailto:mathp@chromium.org.
> 
> The reason for reverting is: As noted, breaks goma builds..

Issue filed as: https://code.google.com/p/chromium/issues/detail?id=417696

Powered by Google App Engine
This is Rietveld 408576698