Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issue 604463002: Fix roll_dep.py to print the right latest SVN revision number on error. (Closed)

Created:
6 years, 3 months ago by Lei Zhang
Modified:
6 years, 3 months ago
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Project:
tools
Visibility:
Public.

Description

Fix roll_dep.py to print the right latest SVN revision number on error. TEST="roll_dep.py breakpad/src 10000" should print ~1387, not 4. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=292129

Patch Set 1 #

Patch Set 2 : 80 chars #

Total comments: 2

Patch Set 3 : address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M roll_dep.py View 1 2 3 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Lei Zhang
6 years, 3 months ago (2014-09-24 18:56:37 UTC) #2
szager1
lgtm with nit, thanks. https://codereview.chromium.org/604463002/diff/20001/roll_dep.py File roll_dep.py (right): https://codereview.chromium.org/604463002/diff/20001/roll_dep.py#newcode130 roll_dep.py:130: if not latest_svn_rev: if not ...
6 years, 3 months ago (2014-09-24 23:36:33 UTC) #3
Lei Zhang (Do not use)
https://codereview.chromium.org/604463002/diff/20001/roll_dep.py File roll_dep.py (right): https://codereview.chromium.org/604463002/diff/20001/roll_dep.py#newcode130 roll_dep.py:130: if not latest_svn_rev: On 2014/09/24 23:36:33, szager1 wrote: > ...
6 years, 3 months ago (2014-09-24 23:45:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/604463002/40001
6 years, 3 months ago (2014-09-24 23:46:27 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-24 23:48:36 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as 292129

Powered by Google App Engine
This is Rietveld 408576698