Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 604453002: Remove unused code from MessageCenterNotificationManager. (Closed)

Created:
6 years, 3 months ago by Jun Mukai
Modified:
6 years, 2 months ago
Reviewers:
dewittj
CC:
chromium-reviews, peter+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove unused code from MessageCenterNotificationManager. Bunch of includes are actually unnecessary, simply removed them. For the fullscreen state, I believe FullscreenNotificationBlocker can handle it correctly. MessageCenterNotificationManager doesn't have to handle it anymore. BUG=None R=dewittj@chromium.org TEST=manually Committed: https://crrev.com/bf6bf16715f0183864ad0b8535ddecc91666ed25 Cr-Commit-Position: refs/heads/master@{#296806}

Patch Set 1 #

Patch Set 2 : test remove #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -62 lines) Patch
M chrome/browser/notifications/message_center_notification_manager.h View 4 chunks +1 line, -13 lines 0 comments Download
M chrome/browser/notifications/message_center_notification_manager.cc View 1 4 chunks +0 lines, -22 lines 0 comments Download
M chrome/browser/notifications/message_center_notifications_browsertest.cc View 1 3 chunks +0 lines, -27 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Jun Mukai
6 years, 3 months ago (2014-09-24 18:13:59 UTC) #1
dewittj
lgtm!
6 years, 3 months ago (2014-09-24 18:15:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/604453002/1
6 years, 3 months ago (2014-09-24 18:19:56 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/70857)
6 years, 2 months ago (2014-09-24 18:50:41 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/604453002/20001
6 years, 2 months ago (2014-09-25 19:53:28 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 48f34ededd2af3ca7d08628a54573d7a1a57f186
6 years, 2 months ago (2014-09-25 22:16:18 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-09-25 22:16:52 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bf6bf16715f0183864ad0b8535ddecc91666ed25
Cr-Commit-Position: refs/heads/master@{#296806}

Powered by Google App Engine
This is Rietveld 408576698