Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 60443003: Makes MouseWatcher work while in metro mode (Closed)

Created:
7 years, 1 month ago by sky
Modified:
7 years, 1 month ago
CC:
chromium-reviews, tfarina, ben+views_chromium.org
Visibility:
Public.

Description

Makes MouseWatcher work while in metro mode I'm changing the aura implementation to use Env::AddPreTargetListener. This way I don't need MessageLoop specific code and it'll work correctly for win on both metro and non-metro. BUG=315155 TEST=none R=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233270

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+142 lines, -18 lines) Patch
M ui/views/mouse_watcher.cc View 4 chunks +74 lines, -18 lines 1 comment Download
M ui/views/views.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
A ui/views/widget/desktop_aura/desktop_event_client.h View 1 chunk +31 lines, -0 lines 0 comments Download
A ui/views/widget/desktop_aura/desktop_event_client.cc View 1 chunk +26 lines, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_native_widget_aura.h View 2 chunks +2 lines, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_native_widget_aura.cc View 3 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
sky
https://codereview.chromium.org/60443003/diff/1/ui/views/mouse_watcher.cc File ui/views/mouse_watcher.cc (right): https://codereview.chromium.org/60443003/diff/1/ui/views/mouse_watcher.cc#newcode29 ui/views/mouse_watcher.cc:29: #if defined(OS_WIN) && !defined(USE_AURA) I'm going with totally different ...
7 years, 1 month ago (2013-11-05 18:52:56 UTC) #1
Ben Goodger (Google)
lgtm
7 years, 1 month ago (2013-11-05 19:07:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/60443003/1
7 years, 1 month ago (2013-11-05 19:13:45 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=94141
7 years, 1 month ago (2013-11-05 23:31:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/60443003/1
7 years, 1 month ago (2013-11-05 23:56:35 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=94346
7 years, 1 month ago (2013-11-06 03:41:55 UTC) #6
sky
7 years, 1 month ago (2013-11-06 14:34:02 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 manually as r233270 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698