Fixing problem with user image in settings page when page gets called as visiting window on a multi…

Fixing problem with user image in settings page when page gets called as visiting window on a multi profile desktop

In Multi profile scenarios, a window can visit another users desktop and as such using the current user is incorrect. Instead the user from the current browser's profile should be taken to determine the user image.

BUG=315078
TEST=visual

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233225

[Mr4D (OOO till 08-26), 2013-11-05 17:54:41]

Please have a look!

[James Hawkins, 2013-11-05 18:51:44]

LGTM with optional nit.

https://codereview.chromium.org/60443002/diff/40001/chrome/browser/ui/webui/o...
File chrome/browser/ui/webui/options/browser_options_handler.cc (right):

https://codereview.chromium.org/60443002/diff/40001/chrome/browser/ui/webui/o...
chrome/browser/ui/webui/options/browser_options_handler.cc:473:
values->SetString("username", name.empty() ? name :
Optional nit: Might be more readable to the latter part out into a new variable,
e.g.,

std::string username = name.empty() ? ...
value->SetString("username", username);

[Dmitry Polukhin, 2013-11-05 19:02:57]

lgtm

[Mr4D (OOO till 08-26), 2013-11-05 19:07:07]

Thanks for your review!

https://codereview.chromium.org/60443002/diff/40001/chrome/browser/ui/webui/o...
File chrome/browser/ui/webui/options/browser_options_handler.cc (right):

https://codereview.chromium.org/60443002/diff/40001/chrome/browser/ui/webui/o...
chrome/browser/ui/webui/options/browser_options_handler.cc:473:
values->SetString("username", name.empty() ? name :
Not quite sure if it is better readable, but done.

[commit-bot: I haz the power, 2013-11-05 19:13:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/skuhne@chromium.org/60443002/230001

[commit-bot: I haz the power, 2013-11-06 05:55:36]

Change committed as 233225