Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2208)

Unified Diff: chrome/browser/resources/chromeos/chromevox/chromevox/injected/live_regions.js

Issue 604423002: Use an enum for ChromeVox queue mode. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/chromeos/chromevox/chromevox/injected/live_regions.js
diff --git a/chrome/browser/resources/chromeos/chromevox/chromevox/injected/live_regions.js b/chrome/browser/resources/chromeos/chromevox/chromevox/injected/live_regions.js
index c72efde8aa2c311181c40f039a57f328b23548f1..a08723f2e949b8c0f61521e20dcfba4ed83ac421 100644
--- a/chrome/browser/resources/chromeos/chromevox/chromevox/injected/live_regions.js
+++ b/chrome/browser/resources/chromeos/chromevox/chromevox/injected/live_regions.js
@@ -82,16 +82,12 @@ cvox.LiveRegions.nodesAlreadyHandled = [];
/**
* @param {Date} pageLoadTime The time the page was loaded. Live region
* updates within the first INITIAL_SILENCE_MS milliseconds are ignored.
- * @param {number} queueMode Interrupt or flush. Polite live region
+ * @param {cvox.QueueMode} queueMode Interrupt or flush. Polite live region
* changes always queue.
* @param {boolean} disableSpeak true if change announcement should be disabled.
* @return {boolean} true if any regions announced.
*/
cvox.LiveRegions.init = function(pageLoadTime, queueMode, disableSpeak) {
- if (queueMode == undefined) {
- queueMode = cvox.AbstractTts.QUEUE_MODE_FLUSH;
- }
-
cvox.LiveRegions.pageLoadTime = pageLoadTime;
if (disableSpeak || !document.hasFocus()) {
@@ -109,8 +105,8 @@ cvox.LiveRegions.init = function(pageLoadTime, queueMode, disableSpeak) {
false,
false,
function(assertive, navDescriptions) {
- if (!assertive && queueMode == cvox.AbstractTts.QUEUE_MODE_FLUSH) {
- queueMode = cvox.AbstractTts.QUEUE_MODE_QUEUE;
+ if (!assertive && queueMode == cvox.QueueMode.FLUSH) {
+ queueMode = cvox.QueueMode.QUEUE;
}
var descSpeaker = new cvox.NavigationSpeaker();
descSpeaker.speakDescriptionArray(navDescriptions, queueMode, null);

Powered by Google App Engine
This is Rietveld 408576698