Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 604413002: Add a temporary variable to store ANGLE gyp file. (Closed)

Created:
6 years, 2 months ago by Jamie Madill
Modified:
6 years, 2 months ago
Reviewers:
brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add a temporary variable to store ANGLE gyp file. This will allow us to correctly transition to the new angle.gypi from the old build_angle.gypi. BUG=415893 Committed: https://crrev.com/90d07e614c526dd382e7dbb64732a73781b31af3 Cr-Commit-Position: refs/heads/master@{#297017}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M build/common.gypi View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Jamie Madill
PTAL Brett, re our conversation about updating the angle gyp filename.
6 years, 2 months ago (2014-09-26 18:42:16 UTC) #2
brettw
lgtm
6 years, 2 months ago (2014-09-26 19:20:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/604413002/1
6 years, 2 months ago (2014-09-26 20:04:17 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as db7f633cabc9abfea8815ae84678c18800c3022d
6 years, 2 months ago (2014-09-26 20:09:34 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-09-26 20:10:14 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/90d07e614c526dd382e7dbb64732a73781b31af3
Cr-Commit-Position: refs/heads/master@{#297017}

Powered by Google App Engine
This is Rietveld 408576698