Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 604383003: Credential Manager: Add the API to about:flags. (Closed)

Created:
6 years, 2 months ago by Mike West
Modified:
6 years, 2 months ago
CC:
chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, jam, nasko+codewatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Credential Manager: Add the API to about:flags. BUG=400674 TBR=isherman@chromium.org Committed: https://crrev.com/531d29fa7137da6318c69ca7106f528bc227eacd Cr-Commit-Position: refs/heads/master@{#297791}

Patch Set 1 #

Patch Set 2 : Histograms. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -0 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/child/runtime_features.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M content/public/common/content_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/content_switches.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
Mike West
WDYT, friendly everything/ OWNER? (Chromium side of https://codereview.chromium.org/617003006/, needs that to roll in before it ...
6 years, 2 months ago (2014-10-01 12:49:19 UTC) #2
jochen (gone - plz use gerrit)
i bet this doesn't pass unit tests (needs some change to histograms.xml) otherwise lgtm
6 years, 2 months ago (2014-10-01 14:04:40 UTC) #3
Mike West
TBRing you, Ilya, for the trivial histograms change. :)
6 years, 2 months ago (2014-10-02 08:31:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/604383003/20001
6 years, 2 months ago (2014-10-02 08:32:26 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/21057)
6 years, 2 months ago (2014-10-02 08:40:41 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/604383003/20001
6 years, 2 months ago (2014-10-02 08:47:27 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 6a4260581179ac30cf8af7aa03211ecc0a7d592d
6 years, 2 months ago (2014-10-02 09:42:16 UTC) #12
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/531d29fa7137da6318c69ca7106f528bc227eacd Cr-Commit-Position: refs/heads/master@{#297791}
6 years, 2 months ago (2014-10-02 09:42:50 UTC) #13
Ilya Sherman
6 years, 2 months ago (2014-10-02 20:34:27 UTC) #14
Message was sent while issue was closed.
histograms lgtm

Powered by Google App Engine
This is Rietveld 408576698