Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 604373008: Serialize all external strings except for native source code strings. (Closed)

Created:
6 years, 2 months ago by Yang
Modified:
6 years, 2 months ago
Reviewers:
mvstanton
CC:
v8-dev, Paweł Hajdan Jr.
Project:
v8
Visibility:
Public.

Description

Serialize all external strings except for native source code strings. R=mvstanton@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24391

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -20 lines) Patch
M include/v8.h View 1 chunk +1 line, -1 line 0 comments Download
M src/bootstrapper.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/heap/heap.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/heap/heap.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M src/serialize.cc View 2 chunks +24 lines, -17 lines 0 comments Download
M test/cctest/test-serialize.cc View 2 chunks +54 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
6 years, 2 months ago (2014-10-02 09:07:18 UTC) #1
mvstanton
Yes, LGTM.
6 years, 2 months ago (2014-10-02 09:17:23 UTC) #2
Yang
6 years, 2 months ago (2014-10-02 09:39:25 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 24391 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698