ui/webui/resources/js/cr/ui/bubble.js - Issue 604373006: Compile chrome://settings, part 9: yet another final battle

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/webui/resources/js/cr/ui/bubble.js

Issue 604373006: Compile chrome://settings, part 9: yet another final battle (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@K_blockers_from_bookmarks

Patch Set: describe supressions Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/webui/resources/js/cr/ui/bubble.js

diff --git a/ui/webui/resources/js/cr/ui/bubble.js b/ui/webui/resources/js/cr/ui/bubble.js

index 10d52e829f75ff0d02a1fa94320bfb99a9932210..d91c8117d74b0967deeab2d9a9c205b04ff3f479 100644

--- a/ui/webui/resources/js/cr/ui/bubble.js

+++ b/ui/webui/resources/js/cr/ui/bubble.js

@@ -494,14 +494,14 @@ cr.define('cr.ui', function() {

// left-click on the bubble's target element (allowing the target to

// handle the event and close the bubble itself).

case 'mousedown':

- if (event.button == 0 &&

- this.anchorNode_.contains(assertInstanceof(event.target, Node))) {

+ var target = assertInstanceof(event.target, Node);

+ if (event.button == 0 && this.anchorNode_.contains(target))

break;

- }

// Close the bubble when the underlying document is scrolled.

case 'mousewheel':

case 'scroll':

- if (this.contains(assertInstanceof(event.target, Node)))

+ var target = assertInstanceof(event.target, Node);

+ if (this.contains(target))

break;

// Close the bubble when the window is resized.

case 'resize':

« no previous file with comments | « third_party/jstemplate/jstemplate.js ('k') | ui/webui/resources/js/cr/ui/list.js » ('j') | no next file with comments »