chrome/browser/resources/options/reset_profile_settings_overlay.js - Issue 604373006: Compile chrome://settings, part 9: yet another final battle

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/options/reset_profile_settings_overlay.js

Issue 604373006: Compile chrome://settings, part 9: yet another final battle (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@K_blockers_from_bookmarks

Patch Set: describe supressions Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/options/reset_profile_settings_banner.js ('k') | chrome/browser/resources/options/website_settings.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/options/reset_profile_settings_overlay.js

diff --git a/chrome/browser/resources/options/reset_profile_settings_overlay.js b/chrome/browser/resources/options/reset_profile_settings_overlay.js

index 60cf57d450bc067ec682ca66c4f486f1f370443f..1152b70d1abfad7f797328c71052de05be8b9335 100644

--- a/chrome/browser/resources/options/reset_profile_settings_overlay.js

+++ b/chrome/browser/resources/options/reset_profile_settings_overlay.js

@@ -44,7 +44,12 @@ cr.define('options', function() {

};

- /** @override */

+ /**

+ * @override

+ * @suppress {checkTypes}

+ * TODO(vitalyp): remove the suppression. See the explanation in

+ * chrome/browser/resources/options/automatic_settings_reset_banner.js.

+ */

didShowPage: function() {

ResetProfileSettingsBanner.dismiss();

chrome.send('onShowResetProfileDialog');

@@ -70,6 +75,9 @@ cr.define('options', function() {

/**

* Chrome callback to notify ResetProfileSettingsOverlay that the reset

* operation has terminated.

+ * @suppress {checkTypes}

+ * TODO(vitalyp): remove the suppression. See the explanation in

+ * chrome/browser/resources/options/automatic_settings_reset_banner.js.

ResetProfileSettingsOverlay.doneResetting = function() {

AutomaticSettingsResetBanner.dismiss();