Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2577)

Unified Diff: chrome/browser/resources/options/controlled_setting.js

Issue 604373006: Compile chrome://settings, part 9: yet another final battle (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@K_blockers_from_bookmarks
Patch Set: describe supressions Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/controlled_setting.js
diff --git a/chrome/browser/resources/options/controlled_setting.js b/chrome/browser/resources/options/controlled_setting.js
index df428faea98fc5c99c450b330199696aa81e60be..652af10613ac31aedb53de81f9b35d7dfe1678c1 100644
--- a/chrome/browser/resources/options/controlled_setting.js
+++ b/chrome/browser/resources/options/controlled_setting.js
@@ -55,6 +55,12 @@ cr.define('options', function() {
* Handle changes to the associated pref by hiding any currently visible
* bubble and updating the controlledBy property.
* @param {Event} event Pref change event.
+ * @suppress {checkTypes}
+ * TODO(vitalyp): remove the suppression. |controlledBy| property is defined
+ * by cr.defineProperty(). Currently null can't be assigned to such
+ * properties due to implementation of ChromePass.java. See this discussion
+ * to change nulls to empty string below:
+ * https://chromiumcodereview.appspot.com/11066015/
*/
handlePrefChange: function(event) {
PageManager.hideBubble();
« no previous file with comments | « chrome/browser/resources/options/compiled_resources.gyp ('k') | chrome/browser/resources/options/options.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698