Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3849)

Unified Diff: chrome/browser/resources/options/chromeos/onc_data.js

Issue 604373006: Compile chrome://settings, part 9: yet another final battle (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@K_blockers_from_bookmarks
Patch Set: describe supressions Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/chromeos/onc_data.js
diff --git a/chrome/browser/resources/options/chromeos/onc_data.js b/chrome/browser/resources/options/chromeos/onc_data.js
index 0329fb38192015500576690370931531793c06ea..d6dfcf647fb34abce0ac39e7d541bc99f3c5097b 100644
--- a/chrome/browser/resources/options/chromeos/onc_data.js
+++ b/chrome/browser/resources/options/chromeos/onc_data.js
@@ -10,11 +10,6 @@
cr.exportPath('cr.onc');
-/**
- * @typedef {(Object|Array|string|number|undefined)}
- */
-cr.onc.OncValue;
-
cr.define('cr.onc', function() {
'use strict';
@@ -30,8 +25,8 @@ cr.define('cr.onc', function() {
/**
* Returns either a managed property dictionary or an unmanaged value.
* @param {string} key The property key.
- * @return {cr.onc.OncValue} The property value or dictionary if it exists,
- * otherwise undefined.
+ * @return {?} The property value or dictionary if it exists, otherwise
+ * undefined.
*/
getManagedProperty: function(key) {
var data = this.data_;
@@ -84,7 +79,7 @@ cr.define('cr.onc', function() {
/**
* Gets the active value of a property.
* @param {string} key The property key.
- * @return {cr.onc.OncValue} The property value or undefined.
+ * @return {?} The property value or undefined.
*/
getActiveValue: function(key) {
var property = this.getManagedProperty(key);
@@ -106,8 +101,7 @@ cr.define('cr.onc', function() {
* Gets the translated ONC value from the result of getActiveValue() using
* loadTimeData. If no translation exists, returns the untranslated value.
* @param {string} key The property key.
- * @return {cr.onc.OncValue} The translation if available or the value if
- * not.
+ * @return {?} The translation if available or the value if not.
*/
getTranslatedValue: function(key) {
var value = this.getActiveValue(key);
@@ -131,7 +125,7 @@ cr.define('cr.onc', function() {
/**
* Gets the recommended value of a property.
* @param {string} key The property key.
- * @return {cr.onc.OncValue} The property value or undefined.
+ * @return {?} The property value or undefined.
*/
getRecommendedValue: function(key) {
var property = this.getManagedProperty(key);
@@ -173,7 +167,7 @@ cr.define('cr.onc', function() {
/**
* Get the effective value from a Managed property ONC dictionary.
* @param {Object} property The managed property ONC dictionary.
- * @return {cr.onc.OncValue} The effective value or undefined.
+ * @return {?} The effective value or undefined.
* @private
*/
getEffectiveValueFromProperty_: function(property) {
« no previous file with comments | « chrome/browser/resources/options/chromeos/network_list.js ('k') | chrome/browser/resources/options/compiled_resources.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698