Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 604363003: Fix ssl_session_cache_openssl.cc hash function. (Closed)

Created:
6 years, 2 months ago by davidben
Modified:
6 years, 2 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix ssl_session_cache_openssl.cc hash function. That's not a polynomial hash. Match base/strings/string_piece.h's hash. BUG=none Committed: https://crrev.com/0204a6fc0652d1e1e02387a5c7770711624e1b2e Cr-Commit-Position: refs/heads/master@{#300165}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M net/socket/ssl_session_cache_openssl.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
davidben
Still fighting with C++ rvalue reference hash_map template goo, but here's something I noticed on ...
6 years, 2 months ago (2014-10-01 23:12:37 UTC) #2
davidben
friendly ping
6 years, 2 months ago (2014-10-13 18:05:47 UTC) #3
Ryan Sleevi
lgtm
6 years, 2 months ago (2014-10-17 20:43:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/604363003/1
6 years, 2 months ago (2014-10-17 21:21:24 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-17 21:29:33 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-17 21:30:11 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0204a6fc0652d1e1e02387a5c7770711624e1b2e
Cr-Commit-Position: refs/heads/master@{#300165}

Powered by Google App Engine
This is Rietveld 408576698