Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(441)

Unified Diff: components/password_manager/core/browser/password_manager.cc

Issue 604293002: Improve logging in password manager internals page (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_manager.cc
diff --git a/components/password_manager/core/browser/password_manager.cc b/components/password_manager/core/browser/password_manager.cc
index 01213bb818fa21e91f3e9fc686d37891494326ef..aa5744e18b28bbd180072f8f6e54e81f47647f72 100644
--- a/components/password_manager/core/browser/password_manager.cc
+++ b/components/password_manager/core/browser/password_manager.cc
@@ -487,7 +487,10 @@ void PasswordManager::OnPasswordFormsRendered(
if (ShouldPromptUserToSavePassword()) {
if (logger)
logger->LogMessage(Logger::STRING_DECISION_ASK);
- client_->PromptUserToSavePassword(provisional_save_manager_.Pass());
+ if (client_->PromptUserToSavePassword(provisional_save_manager_.Pass())) {
+ if (logger)
+ logger->LogMessage(Logger::STRING_SHOW_PASSWORD_PROMPT);
+ }
} else {
if (logger)
logger->LogMessage(Logger::STRING_DECISION_SAVE);

Powered by Google App Engine
This is Rietveld 408576698