components/autofill/core/common/save_password_progress_logger.cc - Issue 604293002: Improve logging in password manager internals page

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/common/save_password_progress_logger.cc

Issue 604293002: Improve logging in password manager internals page (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/autofill/core/common/save_password_progress_logger.cc

diff --git a/components/autofill/core/common/save_password_progress_logger.cc b/components/autofill/core/common/save_password_progress_logger.cc

index 1e73ef6807fa799a29e899d667f47e6ce09cab6e..bb852de9b9ed00e7c2e21b98ae735f40973e4097 100644

--- a/components/autofill/core/common/save_password_progress_logger.cc

+++ b/components/autofill/core/common/save_password_progress_logger.cc

@@ -159,6 +159,8 @@ std::string GetStringFromID(SavePasswordProgressLogger::StringID id) {

return "SSL errors present";

case SavePasswordProgressLogger::STRING_ONLY_VISIBLE:

return "only_visible";

+ case SavePasswordProgressLogger::STRING_SHOW_PASSWORD_PROMPT:

+ return "Show password prompt";

case SavePasswordProgressLogger::STRING_INVALID:

return "INVALID";

// Intentionally no default: clause here -- all IDs need to get covered.