Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Unified Diff: content/renderer/media/webcontentdecryptionmodulesession_impl.cc

Issue 604283003: Refactor CdmPromise and related classes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/webcontentdecryptionmodulesession_impl.cc
diff --git a/content/renderer/media/webcontentdecryptionmodulesession_impl.cc b/content/renderer/media/webcontentdecryptionmodulesession_impl.cc
index 7cd33b4c60e21d15eaf6d8bb74690be86bbd1a96..d21b8482861f4d1b632686343fef77fc0f165e7c 100644
--- a/content/renderer/media/webcontentdecryptionmodulesession_impl.cc
+++ b/content/renderer/media/webcontentdecryptionmodulesession_impl.cc
@@ -30,7 +30,8 @@ class NewSessionCdmResultPromise : public CdmResultPromise<std::string> {
new_session_created_cb_(new_session_created_cb) {}
protected:
- virtual void OnResolve(const std::string& web_session_id) OVERRIDE {
+ virtual void resolve(const std::string& web_session_id) OVERRIDE {
+ ReportResultToUMA(SUCCESS);
blink::WebContentDecryptionModuleResult::SessionStatus status =
new_session_created_cb_.Run(web_session_id);
web_cdm_result_.completeWithSession(status);
@@ -129,7 +130,8 @@ void WebContentDecryptionModuleSessionImpl::update(
web_session_id_,
response,
response_length,
- scoped_ptr<media::SimpleCdmPromise>(new SimpleCdmResultPromise(result)));
+ scoped_ptr<media::SimpleCdmPromise>(
+ new SimpleCdmResultPromise(result, std::string())));
}
void WebContentDecryptionModuleSessionImpl::close(
@@ -137,7 +139,8 @@ void WebContentDecryptionModuleSessionImpl::close(
DCHECK(!web_session_id_.empty());
adapter_->CloseSession(
web_session_id_,
- scoped_ptr<media::SimpleCdmPromise>(new SimpleCdmResultPromise(result)));
+ scoped_ptr<media::SimpleCdmPromise>(
+ new SimpleCdmResultPromise(result, std::string())));
}
void WebContentDecryptionModuleSessionImpl::remove(
@@ -145,7 +148,8 @@ void WebContentDecryptionModuleSessionImpl::remove(
DCHECK(!web_session_id_.empty());
adapter_->RemoveSession(
web_session_id_,
- scoped_ptr<media::SimpleCdmPromise>(new SimpleCdmResultPromise(result)));
+ scoped_ptr<media::SimpleCdmPromise>(
+ new SimpleCdmResultPromise(result, std::string())));
}
void WebContentDecryptionModuleSessionImpl::getUsableKeyIds(
@@ -154,7 +158,7 @@ void WebContentDecryptionModuleSessionImpl::getUsableKeyIds(
adapter_->GetUsableKeyIds(
web_session_id_,
scoped_ptr<media::KeyIdsPromise>(
- new CdmResultPromise<media::KeyIdsVector>(result)));
+ new CdmResultPromise<media::KeyIdsVector>(result, std::string())));
}
void WebContentDecryptionModuleSessionImpl::release(

Powered by Google App Engine
This is Rietveld 408576698