Refactor CdmPromise and related classes

content/renderer/media/cdm_result_promise.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_RENDERER_MEDIA_CDM_RESULT_PROMISE_H_
 #define CONTENT_RENDERER_MEDIA_CDM_RESULT_PROMISE_H_
 
 #include <map>
 
 #include "base/basictypes.h"
 #include "media/base/cdm_promise.h"
 #include "third_party/WebKit/public/platform/WebContentDecryptionModuleResult.h"
 
 namespace content {
 
-// Used to convert a WebContentDecryptionModuleResult into a CdmPromise so that
-// it can be passed through Chromium. When CdmPromise::resolve(T) is called,
-// OnResolve(T) will be called and will call the appropriate complete...()
-// method on WebContentDecryptionModuleResult. If CdmPromise::reject() is called
-// instead, WebContentDecryptionModuleResult::completeWithError() is called.
-// If constructed with a |uma_name| (which must be the name of a
-// CdmPromiseResult UMA), CdmResultPromise will report the promise result
-// (success or rejection code).
-template <typename T>
-class CdmResultPromise : public media::CdmPromiseTemplate<T> {
+// A superset of media::MediaKeys::Exception for UMA reporting. These values
+// should never be changed as it will affect existing reporting, and must match
+// the values for CdmPromiseResult in tools/metrics/histograms/histograms.xml.
+enum ResultCodeForUMA {
+  SUCCESS = 0,
+  NOT_SUPPORTED_ERROR = 1,
+  INVALID_STATE_ERROR = 2,
+  INVALID_ACCESS_ERROR = 3,
+  QUOTA_EXCEEDED_ERROR = 4,
+  UNKNOWN_ERROR = 5,
+  CLIENT_ERROR = 6,
+  OUTPUT_ERROR = 7,
+  NUM_RESULT_CODES
+};
+
+// Used to convert a WebContentDecryptionModuleResult into a CdmPromiseTemplate
+// so that it can be passed through Chromium. When resolve(T) is called, the
+// appropriate complete...() method on WebContentDecryptionModuleResult will be
+// invoked. If reject() is called instead,
+// WebContentDecryptionModuleResult::completeWithError() is called.
+// If constructed with a |uma_name|, CdmResultPromise will report the promise
+// result (success or rejection code) to UMA.
+template <typename... T>
+class CdmResultPromise : public media::CdmPromiseTemplate<T...> {

[xhwang, 2014/10/03 07:34:21]

Cool!

[jrummell, 2014/10/03 18:58:30]

Acknowledged. I like it too.

  public:
-  explicit CdmResultPromise(
-      const blink::WebContentDecryptionModuleResult& result);
   CdmResultPromise(const blink::WebContentDecryptionModuleResult& result,
                    const std::string& uma_name);
   virtual ~CdmResultPromise();
 
+  // CdmPromiseTemplate<T> implementation.
+  virtual void resolve(const T&... result) OVERRIDE;
+  virtual void reject(media::MediaKeys::Exception exception_code,
+                      uint32 system_code,
+                      const std::string& error_message) OVERRIDE;
+
  protected:
-  // OnResolve() is virtual as it may need special handling in derived classes.
-  virtual void OnResolve(const T& result);
-  void OnReject(media::MediaKeys::Exception exception_code,
-                uint32 system_code,
-                const std::string& error_message);
-
   blink::WebContentDecryptionModuleResult web_cdm_result_;
 
  private:

[xhwang, 2014/10/03 07:34:21]

You can have this here:

using media::CdmPromiseTemplate<T...>::PromiseSettled;

so that you don't need the "this->" part in this->PromiseSettled.

[jrummell, 2014/10/03 18:58:30]

Done.

+  // UMA name to report result to.
+  std::string uma_name_;
+
   DISALLOW_COPY_AND_ASSIGN(CdmResultPromise);
 };
 
-// Specialization for no parameter to resolve().
-template <>
-class CdmResultPromise<void> : public media::CdmPromiseTemplate<void> {
- public:
-  explicit CdmResultPromise(
-      const blink::WebContentDecryptionModuleResult& result);
-  CdmResultPromise(const blink::WebContentDecryptionModuleResult& result,
-                   const std::string& uma_name);
-  virtual ~CdmResultPromise();
-
- protected:
-  virtual void OnResolve();
-  void OnReject(media::MediaKeys::Exception exception_code,
-                uint32 system_code,
-                const std::string& error_message);
-
-  blink::WebContentDecryptionModuleResult web_cdm_result_;
-
- private:
-  DISALLOW_COPY_AND_ASSIGN(CdmResultPromise);
-};
-
-typedef CdmResultPromise<void> SimpleCdmResultPromise;
+typedef CdmResultPromise<> SimpleCdmResultPromise;
 
 }  // namespace content
 
 #endif  // CONTENT_RENDERER_MEDIA_CDM_RESULT_PROMISE_H_