Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Unified Diff: ui/android/java/res/layout/date_time_picker_dialog.xml

Issue 604243002: [Android] Add ScrollView to DateTimePicker (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fixed landscape layout Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/android/java/res/layout/date_time_picker_dialog.xml
diff --git a/ui/android/java/res/layout/date_time_picker_dialog.xml b/ui/android/java/res/layout/date_time_picker_dialog.xml
index a02175376dcbea0176791558171f00b3e1862606..09b4bb1ea0713d856043ab9518191d8c15be09f2 100644
--- a/ui/android/java/res/layout/date_time_picker_dialog.xml
+++ b/ui/android/java/res/layout/date_time_picker_dialog.xml
@@ -5,29 +5,36 @@
found in the LICENSE file.
-->
-<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
+<!-- ScrollView is needed since sometimes the dialog does not fit in small screen devices. -->
+<ScrollView xmlns:android="http://schemas.android.com/apk/res/android"
android:layout_width="wrap_content"
- android:layout_height="wrap_content"
- android:layout_gravity="center_horizontal"
- android:orientation="vertical"
- android:gravity="center">
+ android:layout_height="wrap_content">
- <DatePicker
- android:id="@+id/date_picker"
- android:layout_gravity="center_horizontal"
+ <LinearLayout
android:layout_width="wrap_content"
android:layout_height="wrap_content"
- android:spinnersShown="true"
- android:calendarViewShown="false"
- android:contentDescription="@string/accessibility_datetime_picker_date"
- />
-
- <TimePicker
- android:id="@+id/time_picker"
android:layout_gravity="center_horizontal"
- android:layout_width="wrap_content"
- android:layout_height="wrap_content"
- android:contentDescription="@string/accessibility_datetime_picker_time"
- />
+ android:orientation="vertical"
+ android:gravity="center">
+
+ <DatePicker
+ android:id="@+id/date_picker"
+ android:layout_gravity="center_horizontal"
+ android:layout_width="wrap_content"
+ android:layout_height="wrap_content"
+ android:spinnersShown="true"
+ android:calendarViewShown="false"
+ android:contentDescription="@string/accessibility_datetime_picker_date"
+ />
+
+ <TimePicker
+ android:id="@+id/time_picker"
+ android:layout_gravity="center_horizontal"
+ android:layout_width="wrap_content"
+ android:layout_height="wrap_content"
+ android:contentDescription="@string/accessibility_datetime_picker_time"
+ />
+
+ </LinearLayout>
-</LinearLayout>
+</ScrollView>

Powered by Google App Engine
This is Rietveld 408576698