ui/android/java/res/layout-land/date_time_picker_dialog.xml - Issue 604243002: [Android] Add ScrollView to DateTimePicker

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/android/java/res/layout-land/date_time_picker_dialog.xml

Issue 604243002: [Android] Add ScrollView to DateTimePicker (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fixed landscape layout Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « content/public/android/java/res/layout-land/date_time_picker_dialog.xml ('k') | ui/android/java/res/layout/date_time_picker_dialog.xml » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>

	2 <!-- Copyright (c) 2012 The Chromium Authors. All rights reserved.

	3

	4 Use of this source code is governed by a BSD-style license that can be

	5 found in the LICENSE file.

	6 -->

	7

	8 <!-- ScrollView is needed since sometimes the dialog does not fit in small scree n devices. -->

	9 <HorizontalScrollView xmlns:android="http://schemas.android.com/apk/res/android"
	Yaron 2014/09/30 17:29:23 There's already a ./ui/android/java/res/layout/dat There's already a ./ui/android/java/res/layout/date_time_picker_dialog.xml which seems to match the content/ version. Should that be updated as well? Changwan Ryu 2014/09/30 19:26:16 It's included in this cl. :) content resource is b Show quoted text On 2014/09/30 17:29:23, Yaron wrote: > There's already a ./ui/android/java/res/layout/date_time_picker_dialog.xml which > seems to match the content/ version. Should that be updated as well? It's included in this cl. :) content resource is being updated and moved to ui. Yaron 2014/09/30 20:11:19 :S Show quoted text On 2014/09/30 19:26:16, Changwan Ryu wrote: > On 2014/09/30 17:29:23, Yaron wrote: > > There's already a ./ui/android/java/res/layout/date_time_picker_dialog.xml > which > > seems to match the content/ version. Should that be updated as well? > > It's included in this cl. :) content resource is being updated and moved to ui. :S
	10 android:layout_width="wrap_content"

	11 android:layout_height="wrap_content">

	12

	13 <LinearLayout

	14 android:layout_width="wrap_content"

	15 android:layout_height="wrap_content"

	16 android:layout_gravity="center_vertical"

	17 android:orientation="horizontal"

	18 android:gravity="center">

	19

	20 <DatePicker

	21 android:id="@+id/date_picker"

	22 android:layout_gravity="center_vertical"

	23 android:layout_width="wrap_content"

	24 android:layout_height="wrap_content"

	25 android:spinnersShown="true"

	26 android:calendarViewShown="false"

	27 android:contentDescription="@string/accessibility_datetime_picker_da te"

	28 />

	29

	30 <TimePicker

	31 android:id="@+id/time_picker"

	32 android:layout_gravity="center_vertical"

	33 android:layout_width="wrap_content"

	34 android:layout_height="wrap_content"

	35 android:contentDescription="@string/accessibility_datetime_picker_ti me"

	36 />

	37

	38 </LinearLayout>

	39

	40 </HorizontalScrollView>

OLD	NEW