Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 60423008: Simplify LoadableTextTrack construction (Closed)

Created:
7 years, 1 month ago by philipj_slow
Modified:
7 years, 1 month ago
CC:
blink-reviews, nessy, arv+blink, dglazkov+blink, adamk+blink_chromium.org, vcarbune.chromium, Inactive
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Simplify LoadableTextTrack construction HTMLTrackElement::parseAttribute() already sets kind, label and language when the corresponding attributes change, so we can create a TextTrack with the default values, leaving all of the logic for parsing kind in TextTrack::setKind(). This leaves HTMLTrackElement::srclang() and label() unused, so just use [Reflect] in the IDL for these attributes. BUG=315510 TEST=media/track/opera/interfaces/TextTrack/kind.html, media/track/opera/interfaces/TextTrack/label.html, media/track/opera/interfaces/TextTrack/language.html, media/track/track-kind.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161457

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -39 lines) Patch
M Source/core/html/HTMLTrackElement.h View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/core/html/HTMLTrackElement.cpp View 1 chunk +2 lines, -25 lines 0 comments Download
M Source/core/html/HTMLTrackElement.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/track/InbandTextTrack.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/track/LoadableTextTrack.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/track/LoadableTextTrack.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
philipj_slow
7 years, 1 month ago (2013-11-06 10:34:43 UTC) #1
jochen (gone - plz use gerrit)
which test covers this?
7 years, 1 month ago (2013-11-06 10:54:04 UTC) #2
philipj_slow
On 2013/11/06 10:54:04, jochen wrote: > which test covers this? media/track/opera/interfaces/TextTrack/label.html media/track/opera/interfaces/TextTrack/language.html media/track/track-kind.html All of ...
7 years, 1 month ago (2013-11-06 11:41:28 UTC) #3
jochen (gone - plz use gerrit)
cool, lgtm
7 years, 1 month ago (2013-11-06 11:48:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/60423008/1
7 years, 1 month ago (2013-11-06 11:51:03 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=15869
7 years, 1 month ago (2013-11-06 13:20:33 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/60423008/1
7 years, 1 month ago (2013-11-06 13:32:45 UTC) #7
commit-bot: I haz the power
7 years, 1 month ago (2013-11-06 14:40:16 UTC) #8
Message was sent while issue was closed.
Change committed as 161457

Powered by Google App Engine
This is Rietveld 408576698