Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 60423004: MediaCodecBridge: don't try to create .secure codecs pre-JB-MR2. (Closed)

Created:
7 years, 1 month ago by Ami GONE FROM CHROMIUM
Modified:
7 years, 1 month ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Visibility:
Public.

Description

MediaCodecBridge: don't try to create .secure codecs pre-JB-MR2. BUG=314868 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233272

Patch Set 1 : . #

Total comments: 1

Patch Set 2 : added crbug link #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -10 lines) Patch
M media/base/android/java/src/org/chromium/media/MediaCodecBridge.java View 1 2 chunks +19 lines, -10 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Ami GONE FROM CHROMIUM
@wjia: please confirm that this fixes the crashes on RAZR & NexusS running 4.1.* @xhwang: ...
7 years, 1 month ago (2013-11-06 02:08:02 UTC) #1
wjia(left Chromium)
Thanks for the patch! It fixes the crash (apprtc.appspot.com/?debug=loopback). LGTM with one comment. https://codereview.chromium.org/60423004/diff/40001/media/base/android/java/src/org/chromium/media/MediaCodecBridge.java File ...
7 years, 1 month ago (2013-11-06 02:23:27 UTC) #2
Ami GONE FROM CHROMIUM
On Tue, Nov 5, 2013 at 6:23 PM, <wjia@chromium.org> wrote: > Could you add the ...
7 years, 1 month ago (2013-11-06 02:30:20 UTC) #3
xhwang
lgtm
7 years, 1 month ago (2013-11-06 02:31:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fischman@chromium.org/60423004/100001
7 years, 1 month ago (2013-11-06 02:40:10 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests, check_deps http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=220330
7 years, 1 month ago (2013-11-06 05:55:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fischman@chromium.org/60423004/100001
7 years, 1 month ago (2013-11-06 06:15:34 UTC) #7
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=98485
7 years, 1 month ago (2013-11-06 10:06:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fischman@chromium.org/60423004/100001
7 years, 1 month ago (2013-11-06 15:08:19 UTC) #9
commit-bot: I haz the power
7 years, 1 month ago (2013-11-06 16:00:10 UTC) #10
Message was sent while issue was closed.
Change committed as 233272

Powered by Google App Engine
This is Rietveld 408576698