Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 604223002: Fix up gles2 thunk targets a bit (Closed)

Created:
6 years, 2 months ago by jamesr
Modified:
6 years, 2 months ago
Reviewers:
viettrungluu
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@gn_check_mojo
Project:
chromium
Visibility:
Public.

Description

Fix up gles2 thunk targets a bit This puts the gles2 thunks target in a more reasonable location, stops abusing static_library to hide dependency issues, and stop the view manager client side library from pretending to know which sort of gles2 to link against. It uses the gles2 headers but depending on whether the lib is being linked into an application or linked into a target that links in the shell lib (as is done in unit tests) it needs a different implementation. This also deletes the unused //mojo/public/gles2/gles2_interface.h file - if we want this we can pull it back but since nobody is using it now it's kind of a waste of space. If we do want it, it should go in //mojo/public/cpp/gles2 since it's a C++ wrapper. R=viettrungluu@chromium.org Committed: https://crrev.com/8deb674e6cc3bf082bb9c05b6915f7a1d6db9c20 Cr-Commit-Position: refs/heads/master@{#297040}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : declare proper gles2 dependency in png_viewer #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -58 lines) Patch
M mojo/examples/png_viewer/BUILD.gn View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M mojo/public/gles2/BUILD.gn View 2 1 chunk +6 lines, -34 lines 0 comments Download
D mojo/public/gles2/gles2_interface.h View 1 chunk +0 lines, -23 lines 0 comments Download
M mojo/public/platform/native/BUILD.gn View 2 1 chunk +33 lines, -0 lines 0 comments Download
M mojo/services/public/cpp/view_manager/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
jamesr
6 years, 2 months ago (2014-09-26 06:09:58 UTC) #1
jamesr
6 years, 2 months ago (2014-09-26 06:09:58 UTC) #2
viettrungluu
lgtm
6 years, 2 months ago (2014-09-26 15:41:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/604223002/40001
6 years, 2 months ago (2014-09-26 19:37:10 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_dbg/builds/2720)
6 years, 2 months ago (2014-09-26 20:03:45 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/604223002/60001
6 years, 2 months ago (2014-09-26 20:18:24 UTC) #11
commit-bot: I haz the power
Committed patchset #4 (id:60001) as 2a79e36e15727dd08172ca0285b55975992161b6
6 years, 2 months ago (2014-09-26 21:28:42 UTC) #12
commit-bot: I haz the power
6 years, 2 months ago (2014-09-26 21:29:15 UTC) #13
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/8deb674e6cc3bf082bb9c05b6915f7a1d6db9c20
Cr-Commit-Position: refs/heads/master@{#297040}

Powered by Google App Engine
This is Rietveld 408576698