Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6119)

Unified Diff: content/renderer/service_worker/service_worker_script_context.cc

Issue 604193002: ServiceWorker: Add UMA to measure execution times of oninstall/onfetch (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Move UMAs to renderer and measure only the execution time of JS Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/service_worker/service_worker_script_context.cc
diff --git a/content/renderer/service_worker/service_worker_script_context.cc b/content/renderer/service_worker/service_worker_script_context.cc
index fba887b8d46fcc4662814f8c4d9f12a1b0329546..cad0f32eb1f92294baa5b54a3b0442a09da185ef 100644
--- a/content/renderer/service_worker/service_worker_script_context.cc
+++ b/content/renderer/service_worker/service_worker_script_context.cc
@@ -8,6 +8,7 @@
#include "base/debug/trace_event.h"
#include "base/logging.h"
+#include "base/metrics/histogram.h"
#include "content/child/thread_safe_sender.h"
#include "content/child/webmessageportchannel_impl.h"
#include "content/common/service_worker/service_worker_messages.h"
@@ -73,6 +74,11 @@ void ServiceWorkerScriptContext::OnMessageReceived(
void ServiceWorkerScriptContext::DidHandleActivateEvent(
int request_id,
blink::WebServiceWorkerEventResult result) {
+ UMA_HISTOGRAM_TIMES(
+ "ServiceWorker.ActivateEventExecutionTime",
+ base::TimeTicks::Now() - activate_start_timings_[request_id]);
+ activate_start_timings_.erase(request_id);
+
Send(new ServiceWorkerHostMsg_ActivateEventFinished(
GetRoutingID(), request_id, result));
}
@@ -80,6 +86,11 @@ void ServiceWorkerScriptContext::DidHandleActivateEvent(
void ServiceWorkerScriptContext::DidHandleInstallEvent(
int request_id,
blink::WebServiceWorkerEventResult result) {
+ UMA_HISTOGRAM_TIMES(
+ "ServiceWorker.InstallEventExecutionTime",
+ base::TimeTicks::Now() - install_start_timings_[request_id]);
+ install_start_timings_.erase(request_id);
+
Send(new ServiceWorkerHostMsg_InstallEventFinished(
GetRoutingID(), request_id, result));
}
@@ -88,6 +99,11 @@ void ServiceWorkerScriptContext::DidHandleFetchEvent(
int request_id,
ServiceWorkerFetchEventResult result,
const ServiceWorkerResponse& response) {
+ UMA_HISTOGRAM_TIMES(
+ "ServiceWorker.FetchEventExecutionTime",
+ base::TimeTicks::Now() - fetch_start_timings_[request_id]);
+ fetch_start_timings_.erase(request_id);
+
Send(new ServiceWorkerHostMsg_FetchEventFinished(
GetRoutingID(), request_id, result, response));
}
@@ -131,6 +147,7 @@ int ServiceWorkerScriptContext::GetRoutingID() const {
void ServiceWorkerScriptContext::OnActivateEvent(int request_id) {
TRACE_EVENT0("ServiceWorker",
"ServiceWorkerScriptContext::OnActivateEvent");
+ activate_start_timings_[request_id] = base::TimeTicks::Now();
proxy_->dispatchActivateEvent(request_id);
}
@@ -138,6 +155,7 @@ void ServiceWorkerScriptContext::OnInstallEvent(int request_id,
int active_version_id) {
TRACE_EVENT0("ServiceWorker",
"ServiceWorkerScriptContext::OnInstallEvent");
+ install_start_timings_[request_id] = base::TimeTicks::Now();
proxy_->dispatchInstallEvent(request_id);
}
@@ -162,6 +180,7 @@ void ServiceWorkerScriptContext::OnFetchEvent(
webRequest.setReferrer(blink::WebString::fromUTF8(request.referrer.spec()),
blink::WebReferrerPolicyDefault);
webRequest.setIsReload(request.is_reload);
+ fetch_start_timings_[request_id] = base::TimeTicks::Now();
proxy_->dispatchFetchEvent(request_id, webRequest);
}

Powered by Google App Engine
This is Rietveld 408576698