Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1164)

Unified Diff: content/browser/service_worker/service_worker_dispatcher_host.cc

Issue 604193002: ServiceWorker: Add UMA to measure execution times of oninstall/onfetch (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_dispatcher_host.cc
diff --git a/content/browser/service_worker/service_worker_dispatcher_host.cc b/content/browser/service_worker/service_worker_dispatcher_host.cc
index da7979b575e2a67efa4f607a45e7324a76f435ab..77cf793d9df83b389f4baa4501f30515f94fbf33 100644
--- a/content/browser/service_worker/service_worker_dispatcher_host.cc
+++ b/content/browser/service_worker/service_worker_dispatcher_host.cc
@@ -13,6 +13,7 @@
#include "content/browser/service_worker/service_worker_context_core.h"
#include "content/browser/service_worker/service_worker_context_wrapper.h"
#include "content/browser/service_worker/service_worker_handle.h"
+#include "content/browser/service_worker/service_worker_metrics.h"
#include "content/browser/service_worker/service_worker_registration.h"
#include "content/browser/service_worker/service_worker_registration_handle.h"
#include "content/browser/service_worker/service_worker_utils.h"
@@ -251,6 +252,9 @@ void ServiceWorkerDispatcherHost::OnRegisterServiceWorker(
request_id,
"Pattern", pattern.spec(),
"Script URL", script_url.spec());
+ registration_start_timings_.AddWithID(
+ new base::TimeTicks(base::TimeTicks::Now()), request_id);
+
GetContext()->RegisterServiceWorker(
pattern,
script_url,
@@ -479,6 +483,10 @@ void ServiceWorkerDispatcherHost::RegistrationComplete(
ServiceWorkerStatusCode status,
int64 registration_id,
int64 version_id) {
+ scoped_ptr<base::TimeTicks> registration_start_timing(
+ registration_start_timings_.Lookup(request_id));
+ registration_start_timings_.Remove(request_id);
+
if (!GetContext())
return;
@@ -503,6 +511,8 @@ void ServiceWorkerDispatcherHost::RegistrationComplete(
request_id,
"Registration ID", registration_id,
"Version ID", version_id);
+ ServiceWorkerMetrics::MeasureRegistrationTime(
+ base::TimeTicks::Now() - *registration_start_timing);
}
void ServiceWorkerDispatcherHost::OnWorkerReadyForInspection(

Powered by Google App Engine
This is Rietveld 408576698