Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Issue 604173002: Add a timestamp field to QUIC's CachedNetworkParams proto message. (Closed)

Created:
6 years, 2 months ago by ramant (doing other things)
Modified:
6 years, 2 months ago
Reviewers:
wtc, Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, rjshade, wtc, agl
Base URL:
https://chromium.googlesource.com/chromium/src.git@Call_QuicSentPacketManager_75830237
Project:
chromium
Visibility:
Public.

Description

Add a timestamp field to QUIC's CachedNetworkParams proto message. Context in b/17357338, follow-up CL will store CachedNetworkParams and copy into newly created STKs. Merge internal change: 75897792 R=rch@chromium.org

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M net/quic/crypto/source_address_token.h View 2 chunks +5 lines, -0 lines 2 comments Download
M net/quic/quic_server_session.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M net/tools/quic/quic_server_session.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M net/tools/quic/quic_server_session_test.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
ramant (doing other things)
6 years, 2 months ago (2014-09-26 01:27:54 UTC) #1
Ryan Hamilton
lgtm
6 years, 2 months ago (2014-09-26 03:20:12 UTC) #2
wtc
Patch set 1 LGTM. https://codereview.chromium.org/604173002/diff/1/net/quic/crypto/source_address_token.h File net/quic/crypto/source_address_token.h (right): https://codereview.chromium.org/604173002/diff/1/net/quic/crypto/source_address_token.h#newcode101 net/quic/crypto/source_address_token.h:101: int64 timestamp_; Nit: it seems ...
6 years, 2 months ago (2014-09-29 17:15:31 UTC) #4
ramant (doing other things)
6 years, 2 months ago (2014-09-29 17:42:10 UTC) #5
Message was sent while issue was closed.
Thanks much Wan-Teh. Will rename it in the next CL.

https://codereview.chromium.org/604173002/diff/1/net/quic/crypto/source_addre...
File net/quic/crypto/source_address_token.h (right):

https://codereview.chromium.org/604173002/diff/1/net/quic/crypto/source_addre...
net/quic/crypto/source_address_token.h:101: int64 timestamp_;
On 2014/09/29 17:15:30, wtc wrote:
> 
> Nit: it seems that the naming convention includes the time unit ("_seconds" or
> "_ms") in the member's name. See max_bandwidth_timestamp_seconds_ and
> min_rtt_ms_.

Hi Wan-Teh,
  Robbie pointed out it is similar to "timestamp_" field in SourceAddressToken.
Will rename both in a future CL.

Powered by Google App Engine
This is Rietveld 408576698