Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 604143002: Use USE_UDEV instead of OS_LINUX when trying to use Udev functionality (Closed)

Created:
6 years, 2 months ago by dnicoara
Modified:
6 years, 2 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Use USE_UDEV instead of OS_LINUX when trying to use Udev functionality Fixes the Ozone builder where udev isn't available. BUG=none Committed: https://crrev.com/385034b44fb4f96b0258048955a927cc6f1c0cfd Cr-Commit-Position: refs/heads/master@{#296866}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M device/usb/usb_device_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M device/usb/usb_device_impl.cc View 5 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
dnicoara
PTAL, this is a followup to https://codereview.chromium.org/601073002/ to fix the Ozone ECS builder
6 years, 2 months ago (2014-09-25 23:27:34 UTC) #2
Reilly Grant (use Gerrit)
lgtm
6 years, 2 months ago (2014-09-26 00:34:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/604143002/1
6 years, 2 months ago (2014-09-26 02:48:05 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 8da6db38e49a580f1a1420358a6051b8a526544c
6 years, 2 months ago (2014-09-26 02:52:49 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-09-26 02:53:33 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/385034b44fb4f96b0258048955a927cc6f1c0cfd
Cr-Commit-Position: refs/heads/master@{#296866}

Powered by Google App Engine
This is Rietveld 408576698