Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 604083003: Update shipping version of vs_addin. (Closed)

Created:
6 years, 2 months ago by Sam Clegg
Modified:
6 years, 2 months ago
Reviewers:
binji
CC:
chromium-reviews, binji+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Update shipping version of vs_addin. This brings in the following changes to the addin: r1578 Add default compiler include paths to visual studio r1577 Cleanup create_package.py r1576 Fix several issues with debugging PPAPI plugins r1575 Update versions used for testing the addin r1574 Only skip uploading of addin if the file already exists on google storage. BUG= https://code.google.com/p/chromium/issues/detail?id=179121 R=binji@chromium.org Committed: https://crrev.com/52e99c651cafbf8a30a0e6c982e6f22457408fe0 Cr-Commit-Position: refs/heads/master@{#296813}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M native_client_sdk/src/build_tools/json/naclsdk_manifest2.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
Sam Clegg
6 years, 2 months ago (2014-09-25 22:45:29 UTC) #2
binji
lgtm
6 years, 2 months ago (2014-09-25 22:48:58 UTC) #3
Sam Clegg
Committed patchset #1 (id:1) manually as 52e99c6 (presubmit successful).
6 years, 2 months ago (2014-09-25 22:53:58 UTC) #4
commit-bot: I haz the power
6 years, 2 months ago (2014-09-25 22:54:02 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/52e99c651cafbf8a30a0e6c982e6f22457408fe0
Cr-Commit-Position: refs/heads/master@{#296813}

Powered by Google App Engine
This is Rietveld 408576698