Introduce builtin for Array.shift function.

src/builtins.cc

 // Copyright 2006-2008 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 317 matching lines @@
   // Remember to check the prototype chain.
   JSFunction* array_function =
       Top::context()->global_context()->array_function();
   JSObject* prototype = JSObject::cast(array_function->prototype());
   top = prototype->GetElement(len - 1);
 
   return top;
 }
 
 
+BUILTIN(ArrayShift) {
+  JSArray* array = JSArray::cast(*args.receiver());
+  ASSERT(array->HasFastElements());
+  Object* undefined = Heap::undefined_value();

[Mads Ager (chromium), 2010/02/12 13:27:51]

Get rid of the local variable and just put in Heap::undefined_value at the only
use site?

[antonm, 2010/02/12 14:05:55]

Done.

+
+  int len = Smi::cast(array->length())->value();
+  if (len == 0) return undefined;
+
+  // Fetch the prototype.
+  JSFunction* array_function =
+      Top::context()->global_context()->array_function();
+  JSObject* prototype = JSObject::cast(array_function->prototype());
+
+  // Get first element
+  FixedArray* elms = FixedArray::cast(array->elements());
+  Object* first = elms->get(0);
+
+  // Set the length.
+  array->set_length(Smi::FromInt(len - 1));
+
+  if (first->IsTheHole())

[Mads Ager (chromium), 2010/02/12 13:27:51]

Please use braces around the body.

[antonm, 2010/02/12 14:05:55]

Done.

+    first = prototype->GetElement(0);
+
+  for (int i = 0; i < len - 1; i++) {
+    Object* e = elms->get(i + 1);
+    if (e->IsTheHole())

[Mads Ager (chromium), 2010/02/12 13:27:51]

Please use braces around the body.

[antonm, 2010/02/12 14:05:55]

Done.

+      e = prototype->GetElement(i + 1);
+    elms->set(i, e);

[Mads Ager (chromium), 2010/02/12 13:27:51]

Will this preserve array holes?  Won't GetElement return undefined for holes in
the array?  Then set will introduce an element that wasn't there before with an
undefined value?

[antonm, 2010/02/12 14:05:55]

Nice catch, thanks a lot.  Regression test added.  Fixed in not most optimal way
for sparsed arrays (doing HasElement call).  If it'd prove to be a bottleneck,
I'd adjust.

The problem is I didn't find an API to get element which would distinguish
between hole and undefined.  It's easy to add (if indeed missing).

+  }
+  elms->set(len - 1, Heap::the_hole_value());
+
+  return first;
+}
+
+
 // -----------------------------------------------------------------------------
 //
 
 
 // Returns the holder JSObject if the function can legally be called
 // with this receiver.  Returns Heap::null_value() if the call is
 // illegal.  Any arguments that don't fit the expected type is
 // overwritten with undefined.  Arguments that do fit the expected
 // type is overwritten with the object in the prototype chain that
 // actually has that type.
@@ skipping 625 matching lines @@
       if (entry->contains(pc)) {
         return names_[i];
       }
     }
   }
   return NULL;
 }
 
 
 } }  // namespace v8::internal