Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 603983003: Mojo: COMPILE_ASSERT -> static_assert in mojo/system and mojo/embedder. (Closed)

Created:
6 years, 2 months ago by viettrungluu
Modified:
6 years, 2 months ago
Reviewers:
jamesr
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Mojo: COMPILE_ASSERT -> static_assert in mojo/system and mojo/embedder. R=jamesr@chromium.org Committed: https://crrev.com/8e87d53d550ad2b3b254b19b888158be41259b6d Cr-Commit-Position: refs/heads/master@{#296848}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -46 lines) Patch
M mojo/embedder/simple_platform_shared_buffer_posix.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/system/channel.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M mojo/system/handle_signals_state.h View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/system/handle_table.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/system/local_data_pipe_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/system/memory_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M mojo/system/message_in_transit.cc View 1 chunk +7 lines, -7 lines 0 comments Download
M mojo/system/options_validation.h View 1 chunk +6 lines, -4 lines 0 comments Download
M mojo/system/transport_data.cc View 3 chunks +16 lines, -21 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
viettrungluu
6 years, 2 months ago (2014-09-25 23:30:34 UTC) #1
jamesr
lgtm
6 years, 2 months ago (2014-09-25 23:34:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/603983003/1
6 years, 2 months ago (2014-09-26 00:18:18 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as 437ce447ff29a2a4cd4b6587785905eb1207afe8
6 years, 2 months ago (2014-09-26 01:20:04 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-09-26 01:20:48 UTC) #6
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/8e87d53d550ad2b3b254b19b888158be41259b6d
Cr-Commit-Position: refs/heads/master@{#296848}

Powered by Google App Engine
This is Rietveld 408576698