Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 603943003: Clang update.sh: always clear CMake's cache, and only set MACOSX_DEPLOYMENT_TARGET when needed (Closed)

Created:
6 years, 2 months ago by hans
Modified:
6 years, 2 months ago
Reviewers:
Nico
CC:
chromium-reviews, eugenis+clang_chromium.org, glider+clang_chromium.org, dmikurube+clang_chromium.org, ukai+watch_chromium.org, dcheng
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Clang update.sh: always clear CMake's cache, and only set MACOSX_DEPLOYMENT_TARGET when needed Previously it was possible to run into situations where CMake would fail, write a partial CMakeCache.txt, and on the next run of update.sh, we would think the build was already configured and skip the CMake step. This patch removes that problem by always clearing the cache and forcing a full re-run of CMake. This also has the benefit that if the path to the compiler or a compiler flag changes, the build will get updated. Note that doing a full re-run of CMake doesn't mean doing a full re-build. Also, we should only be setting MACOSX_DEPLOYMENT_TARGET when doing bootstrap builds. This patch fixes that too. BUG=415670 Committed: https://crrev.com/835667440fd8753d9b0378470fa74f273b5b2cad Cr-Commit-Position: refs/heads/master@{#296771}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -19 lines) Patch
M tools/clang/scripts/update.sh View 5 chunks +28 lines, -19 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
hans
Please take a look.
6 years, 2 months ago (2014-09-25 18:29:20 UTC) #2
Nico
lgtm
6 years, 2 months ago (2014-09-25 18:47:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/603943003/1
6 years, 2 months ago (2014-09-25 18:50:14 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as dd808507ee580ddb7d5ba572cc8a3ee8c95e0b9e
6 years, 2 months ago (2014-09-25 19:51:53 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-09-25 19:52:25 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/835667440fd8753d9b0378470fa74f273b5b2cad
Cr-Commit-Position: refs/heads/master@{#296771}

Powered by Google App Engine
This is Rietveld 408576698