Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 603943002: Remove 1.3 MB of superfluous media files for LayoutTests (Closed)

Created:
6 years, 2 months ago by philipj_slow
Modified:
6 years, 2 months ago
Reviewers:
fs
CC:
blink-reviews, feature-media-reviews_chromium.org, eric.carlson_apple.com
Project:
blink
Visibility:
Public.

Description

Remove 1.3 MB of superfluous media files for LayoutTests These were unused or use where another file works just as well. Note that test.webm was corrupted (encrypted?) so if it were ever chosen by findMediaFile() it wouldn't work. Also remove unused formats from media-file.js. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182681

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -10 lines) Patch
M LayoutTests/http/tests/security/local-video-source-from-remote.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/local-video-source-from-remote-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/local-video-src-from-remote.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/local-video-src-from-remote-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
D LayoutTests/media/content/720x576i-anamorphic.mov View Binary file 0 comments Download
D LayoutTests/media/content/counting-captioned.mov View Binary file 0 comments Download
D LayoutTests/media/content/counting-subtitled.m4v View Binary file 0 comments Download
D LayoutTests/media/content/empty.oga View 0 chunks +-1 lines, --1 lines 0 comments Download
D LayoutTests/media/content/garbage.mp4 View 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/media/content/garbage.ogv View 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/media/content/scaled-matrix.mov View Binary file 0 comments Download
D LayoutTests/media/content/short.wav View Binary file 0 comments Download
D LayoutTests/media/content/silence.mpg View Binary file 0 comments Download
D LayoutTests/media/content/silence-loop.mov View Binary file 0 comments Download
D LayoutTests/media/content/test.webm View Binary file 0 comments Download
M LayoutTests/media/encrypted-media/encrypted-media-prefixed-after-unprefixed.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/media/encrypted-media/encrypted-media-unprefixed-after-prefixed.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/media/media-file.js View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
philipj_slow
PTAL
6 years, 2 months ago (2014-09-25 14:04:31 UTC) #2
fs
rslgtm
6 years, 2 months ago (2014-09-25 14:22:14 UTC) #3
fs
On 2014/09/25 14:22:14, fs wrote: > rslgtm Meh. LGTM.
6 years, 2 months ago (2014-09-25 14:22:31 UTC) #4
philipj_slow
On 2014/09/25 14:22:31, fs wrote: > On 2014/09/25 14:22:14, fs wrote: > > rslgtm > ...
6 years, 2 months ago (2014-09-25 14:25:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/603943002/1
6 years, 2 months ago (2014-09-25 14:28:01 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-09-25 15:07:26 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as 182681

Powered by Google App Engine
This is Rietveld 408576698