Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4582)

Unified Diff: chrome/common/extensions/manifest_handler.h

Issue 60393005: Revert 232631 - Revert 232499 "Move ManifestHandler to top-level extensions." (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: deps Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/extensions/incognito_handler.h ('k') | chrome/common/extensions/manifest_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/manifest_handler.h
diff --git a/chrome/common/extensions/manifest_handler.h b/chrome/common/extensions/manifest_handler.h
deleted file mode 100644
index 42f989bc4bb0e9dc53617d0773be08257fd02aef..0000000000000000000000000000000000000000
--- a/chrome/common/extensions/manifest_handler.h
+++ /dev/null
@@ -1,138 +0,0 @@
-// Copyright (c) 2013 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#ifndef CHROME_COMMON_EXTENSIONS_MANIFEST_HANDLER_H_
-#define CHROME_COMMON_EXTENSIONS_MANIFEST_HANDLER_H_
-
-#include <set>
-#include <string>
-#include <vector>
-
-#include "base/lazy_instance.h"
-#include "base/memory/linked_ptr.h"
-#include "base/strings/string16.h"
-#include "extensions/common/manifest.h"
-
-namespace extensions {
-class Extension;
-
-// An interface for clients that recognize and parse keys in extension
-// manifests.
-class ManifestHandler {
- public:
- ManifestHandler();
- virtual ~ManifestHandler();
-
- // Attempts to parse the extension's manifest.
- // Returns true on success or false on failure; if false, |error| will
- // be set to a failure message.
- virtual bool Parse(Extension* extension, string16* error) = 0;
-
- // Validate that files associated with this manifest key exist.
- // Validation takes place after parsing. May also append a series of
- // warning messages to |warnings|.
- //
- // Otherwise, returns false, and a description of the error is
- // returned in |error|.
- // TODO(yoz): Change error to string16. See crbug.com/71980.
- virtual bool Validate(const Extension* extension,
- std::string* error,
- std::vector<InstallWarning>* warnings) const;
-
- // If false (the default), only parse the manifest if a registered
- // key is present in the manifest. If true, always attempt to parse
- // the manifest for this extension type, even if no registered keys
- // are present. This allows specifying a default parsed value for
- // extensions that don't declare our key in the manifest.
- // TODO(yoz): Use Feature availability instead.
- virtual bool AlwaysParseForType(Manifest::Type type) const;
-
- // Same as AlwaysParseForType, but for Validate instead of Parse.
- virtual bool AlwaysValidateForType(Manifest::Type type) const;
-
- // The list of keys that, if present, should be parsed before calling our
- // Parse (typically, because our Parse needs to read those keys).
- // Defaults to empty.
- virtual const std::vector<std::string> PrerequisiteKeys() const;
-
- // Associate us with our keys() in the manifest. A handler can register
- // for multiple keys. The global registry takes ownership of this;
- // if it has an existing handler for |key|, it replaces it with this.
- // Manifest handlers must be registered at process startup in
- // chrome_manifest_handlers.cc:
- // (new MyManifestHandler)->Register();
- void Register();
-
- // Calling FinalizeRegistration indicates that there are no more
- // manifest handlers to be registered.
- static void FinalizeRegistration();
-
- static bool IsRegistrationFinalized();
-
- // Call Parse on all registered manifest handlers that should parse
- // this extension.
- static bool ParseExtension(Extension* extension, string16* error);
-
- // Call Validate on all registered manifest handlers for this extension.
- static bool ValidateExtension(const Extension* extension,
- std::string* error,
- std::vector<InstallWarning>* warnings);
-
- protected:
- // A convenience method for handlers that only register for 1 key,
- // so that they can define keys() { return SingleKey(kKey); }
- static const std::vector<std::string> SingleKey(const std::string& key);
-
- private:
- // The keys to register us for (in Register).
- virtual const std::vector<std::string> Keys() const = 0;
-};
-
-// The global registry for manifest handlers.
-class ManifestHandlerRegistry {
- private:
- friend class ManifestHandler;
- friend class ScopedTestingManifestHandlerRegistry;
- friend struct base::DefaultLazyInstanceTraits<ManifestHandlerRegistry>;
-
- ManifestHandlerRegistry();
- ~ManifestHandlerRegistry();
-
- void Finalize();
-
- void RegisterManifestHandler(const std::string& key,
- linked_ptr<ManifestHandler> handler);
- bool ParseExtension(Extension* extension, string16* error);
- bool ValidateExtension(const Extension* extension,
- std::string* error,
- std::vector<InstallWarning>* warnings);
-
- // Overrides the current global ManifestHandlerRegistry with
- // |registry|, returning the current one.
- static ManifestHandlerRegistry* SetForTesting(
- ManifestHandlerRegistry* new_registry);
-
- typedef std::map<std::string, linked_ptr<ManifestHandler> >
- ManifestHandlerMap;
- typedef std::map<ManifestHandler*, int> ManifestHandlerPriorityMap;
-
- // Puts the manifest handlers in order such that each handler comes after
- // any handlers for their PrerequisiteKeys. If there is no handler for
- // a prerequisite key, that dependency is simply ignored.
- // CHECKs that there are no manifest handlers with circular dependencies.
- void SortManifestHandlers();
-
- // All registered manifest handlers.
- ManifestHandlerMap handlers_;
-
- // The priority for each manifest handler. Handlers with lower priority
- // values are evaluated first.
- ManifestHandlerPriorityMap priority_map_;
-
- bool is_finalized_;
-};
-
-} // namespace extensions
-
-#endif // CHROME_COMMON_EXTENSIONS_MANIFEST_HANDLER_H_
« no previous file with comments | « chrome/common/extensions/incognito_handler.h ('k') | chrome/common/extensions/manifest_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698