Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 603913002: [ServiceWorker] Add was_fallback_required flag to ResourceResponseInfo. [2/2 chromium] (Closed)

Created:
6 years, 2 months ago by horo
Modified:
6 years, 2 months ago
CC:
chromium-reviews, darin-cc_chromium.org, horo+watch_chromium.org, jam, jsbell+serviceworker_chromium.org, kinuko+serviceworker, michaeln, nhiroki, serviceworker-reviews, tzik
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[ServiceWorker] Add was_fallback_required flag to ResourceResponseInfo. [2/2 chromium] This flag is set when the request whose mode is CORS or CORS-with-forced-preflight is sent to a ServiceWorker but FetchEvent.respondWith is not called. It is because the CORS preflight logic is implemented in the renderer. So we can't simply fallback to the network in the browser process. [1/2] blink: https://codereview.chromium.org/602073002/ [2/2] chromium: https://codereview.chromium.org/603913002/ This change depends on https://codereview.chromium.org/588153002/. BUG=416371, 408507 Committed: https://crrev.com/00320571a4696025c2216a4f1fe193f13c5f2355 Cr-Commit-Position: refs/heads/master@{#297610}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : Add ByServiceWorker suffix #

Total comments: 2

Patch Set 4 : s/which/whose/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -1 line) Patch
M content/browser/loader/resource_loader.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_context_request_handler.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_context_request_handler.cc View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_controllee_request_handler.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_controllee_request_handler.cc View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_request_handler.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_url_request_job.h View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_url_request_job.cc View 1 2 3 chunks +16 lines, -0 lines 0 comments Download
M content/child/web_url_loader_impl.cc View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M content/common/resource_messages.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/resource_response_info.h View 1 2 3 1 chunk +6 lines, -0 lines 0 comments Download
M content/public/common/resource_response_info.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 28 (11 generated)
horo
yhirano@ Could you please review?
6 years, 2 months ago (2014-09-25 10:54:31 UTC) #2
yhirano
"which mode is CORS" in the description should be "whose mode is CORS". https://codereview.chromium.org/603913002/diff/60001/content/public/common/resource_response_info.h File ...
6 years, 2 months ago (2014-09-26 04:27:25 UTC) #4
horo
done https://codereview.chromium.org/603913002/diff/60001/content/public/common/resource_response_info.h File content/public/common/resource_response_info.h (right): https://codereview.chromium.org/603913002/diff/60001/content/public/common/resource_response_info.h#newcode104 content/public/common/resource_response_info.h:104: // True when the request which mode is ...
6 years, 2 months ago (2014-09-26 05:07:58 UTC) #5
yhirano
lgtm
6 years, 2 months ago (2014-09-26 05:50:06 UTC) #6
horo
nasko@ Could you please review content/common/resource_messages.h?
6 years, 2 months ago (2014-09-26 07:33:55 UTC) #8
nasko
IPC LGTM
6 years, 2 months ago (2014-09-26 13:57:12 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/603913002/80001
6 years, 2 months ago (2014-09-30 13:49:09 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/14422)
6 years, 2 months ago (2014-09-30 13:57:08 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/603913002/80001
6 years, 2 months ago (2014-09-30 16:03:55 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/62525) android_chromium_gn_compile_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/20286) chromium_presubmit ...
6 years, 2 months ago (2014-09-30 16:12:28 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/603913002/80001
6 years, 2 months ago (2014-09-30 22:23:13 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/14591)
6 years, 2 months ago (2014-09-30 22:33:37 UTC) #21
horo
jochen@ Could you please review this?
6 years, 2 months ago (2014-10-01 00:18:17 UTC) #23
jochen (gone - plz use gerrit)
lgtm
6 years, 2 months ago (2014-10-01 07:47:01 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/603913002/80001
6 years, 2 months ago (2014-10-01 07:50:28 UTC) #26
commit-bot: I haz the power
Committed patchset #4 (id:80001) as b6f00aadcafeb26283667a39145e01bceae9d834
6 years, 2 months ago (2014-10-01 07:57:04 UTC) #27
commit-bot: I haz the power
6 years, 2 months ago (2014-10-01 07:58:07 UTC) #28
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/00320571a4696025c2216a4f1fe193f13c5f2355
Cr-Commit-Position: refs/heads/master@{#297610}

Powered by Google App Engine
This is Rietveld 408576698