Source/core/fetch/ImageResourceTest.cpp - Issue 603903003: [Streams] Pass WebDataConsumerHandle when the response arrives.

Unified Diff: Source/core/fetch/ImageResourceTest.cpp

Issue 603903003: [Streams] Pass WebDataConsumerHandle when the response arrives. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@web-data-pipe

Patch Set: rebase Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/fetch/ImageResourceTest.cpp

diff --git a/Source/core/fetch/ImageResourceTest.cpp b/Source/core/fetch/ImageResourceTest.cpp

index ee4728eb3fd64b4522f0484aeaaccd956b1487ab..42fd3dcf720b7065349e6a3ab041a828493c0caa 100644

--- a/Source/core/fetch/ImageResourceTest.cpp

+++ b/Source/core/fetch/ImageResourceTest.cpp

@@ -92,7 +92,7 @@ TEST(ImageResourceTest, MultipartImage)

cachedImage->addClient(&client);

// Send the multipart response. No image or data buffer is created.

- cachedImage->responseReceived(ResourceResponse(KURL(), "multipart/x-mixed-replace", 0, nullAtom, String()));

+ cachedImage->responseReceived(ResourceResponse(KURL(), "multipart/x-mixed-replace", 0, nullAtom, String()), nullptr);

ASSERT_FALSE(cachedImage->resourceBuffer());

ASSERT_FALSE(cachedImage->hasImage());

ASSERT_EQ(client.imageChangedCount(), 0);

@@ -101,7 +101,7 @@ TEST(ImageResourceTest, MultipartImage)

// Send the response for the first real part. No image or data buffer is created.

const char* svgData = "<svg xmlns='http://www.w3.org/2000/svg' width='1' height='1'><rect width='1' height='1' fill='green'/></svg>";

unsigned svgDataLength = strlen(svgData);

- cachedImage->responseReceived(ResourceResponse(KURL(), "image/svg+xml", svgDataLength, nullAtom, String()));

+ cachedImage->responseReceived(ResourceResponse(KURL(), "image/svg+xml", svgDataLength, nullAtom, String()), nullptr);

ASSERT_FALSE(cachedImage->resourceBuffer());

ASSERT_FALSE(cachedImage->hasImage());

ASSERT_EQ(client.imageChangedCount(), 0);

@@ -169,10 +169,10 @@ TEST(ImageResourceTest, DecodedDataRemainsWhileHasClients)

cachedImage->addClient(&client);

// Send the image response.

- cachedImage->responseReceived(ResourceResponse(KURL(), "multipart/x-mixed-replace", 0, nullAtom, String()));

+ cachedImage->responseReceived(ResourceResponse(KURL(), "multipart/x-mixed-replace", 0, nullAtom, String()), nullptr);

Vector<unsigned char> jpeg = jpegImage();

- cachedImage->responseReceived(ResourceResponse(KURL(), "image/jpeg", jpeg.size(), nullAtom, String()));

+ cachedImage->responseReceived(ResourceResponse(KURL(), "image/jpeg", jpeg.size(), nullAtom, String()), nullptr);

cachedImage->appendData(reinterpret_cast<const char*>(jpeg.data()), jpeg.size());

cachedImage->finish();

ASSERT_FALSE(cachedImage->errorOccurred());

@@ -203,10 +203,10 @@ TEST(ImageResourceTest, UpdateBitmapImages)

cachedImage->addClient(&client);

// Send the image response.

- cachedImage->responseReceived(ResourceResponse(KURL(), "multipart/x-mixed-replace", 0, nullAtom, String()));

+ cachedImage->responseReceived(ResourceResponse(KURL(), "multipart/x-mixed-replace", 0, nullAtom, String()), nullptr);

Vector<unsigned char> jpeg = jpegImage();

- cachedImage->responseReceived(ResourceResponse(KURL(), "image/jpeg", jpeg.size(), nullAtom, String()));

+ cachedImage->responseReceived(ResourceResponse(KURL(), "image/jpeg", jpeg.size(), nullAtom, String()), nullptr);

cachedImage->appendData(reinterpret_cast<const char*>(jpeg.data()), jpeg.size());

cachedImage->finish();

ASSERT_FALSE(cachedImage->errorOccurred());

« no previous file with comments | « Source/core/fetch/ImageResource.cpp ('k') | Source/core/fetch/RawResource.h » ('j') | Source/core/fetch/RawResource.cpp » ('J')