Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issue 603903003: [Streams] Pass WebDataConsumerHandle when the response arrives. (Closed)

Created:
6 years, 2 months ago by yhirano
Modified:
6 years, 1 month ago
CC:
blink-reviews, jamesr, tzik, webcomponents-bugzilla_chromium.org, eae+blinkwatch, apavlov+blink_chromium.org, kinuko+worker_chromium.org, aandrey+blink_chromium.org, falken, caseq+blink_chromium.org, blink-reviews-events_chromium.org, malch+blink_chromium.org, blink-reviews-html_chromium.org, yurys+blink_chromium.org, dglazkov+blink, gavinp+loader_chromium.org, devtools-reviews_chromium.org, loislo+blink_chromium.org, jsbell+serviceworker_chromium.org, nhiroki, eustas+blink_chromium.org, paulirish+reviews_chromium.org, lushnikov+blink_chromium.org, Nate Chapin, michaeln, serviceworker-reviews, mkwst+moarreviews_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, kinuko+serviceworker, horo+watch_chromium.org, sergeyv+blink_chromium.org, kinuko+fileapi
Base URL:
https://chromium.googlesource.com/chromium/blink.git@web-data-pipe
Project:
blink
Visibility:
Public.

Description

[Streams] Pass WebDataConsumerHandle when the response arrives. We are implementing the Streams API. To make back-pressure take effect, we should allow the resource loading customer such as XHR or the Fetch API to read the data manually. This CL adds a WebDataConsumerHandle to didReceiveResponse parameters. This CL does not change the behavior as of now. The tricky part is how to deal with a handle. As WebDataConsumerHandle cannot be shared by multiple clients, we can't add the handle in the response. Moreover, we assert that handle must be null when more than one client exists in RawResource.cpp. BUG=418879 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184892

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : rebase #

Total comments: 4

Patch Set 5 : rebase #

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -66 lines) Patch
M Source/core/fetch/ImageResource.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/core/fetch/ImageResource.cpp View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/fetch/ImageResourceTest.cpp View 4 chunks +6 lines, -6 lines 0 comments Download
M Source/core/fetch/RawResource.h View 1 2 3 3 chunks +4 lines, -2 lines 0 comments Download
M Source/core/fetch/RawResource.cpp View 1 2 3 4 5 2 chunks +9 lines, -5 lines 0 comments Download
M Source/core/fetch/RawResourceTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/fetch/Resource.h View 1 2 3 4 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/fetch/Resource.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M Source/core/fetch/ResourceFetcher.cpp View 1 2 3 4 2 chunks +3 lines, -2 lines 0 comments Download
M Source/core/fetch/ResourceLoader.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/fetch/ResourceLoader.cpp View 1 2 3 4 3 chunks +9 lines, -2 lines 0 comments Download
M Source/core/fileapi/FileReaderLoader.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/core/fileapi/FileReaderLoader.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/html/imports/HTMLImportLoader.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/imports/HTMLImportLoader.cpp View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/inspector/InspectorResourceAgent.cpp View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/loader/DocumentLoader.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/DocumentLoader.cpp View 1 2 3 2 chunks +3 lines, -2 lines 0 comments Download
M Source/core/loader/DocumentThreadableLoader.h View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/loader/DocumentThreadableLoader.cpp View 1 2 3 5 chunks +6 lines, -6 lines 0 comments Download
M Source/core/loader/ThreadableLoaderClient.h View 2 chunks +3 lines, -1 line 0 comments Download
M Source/core/loader/ThreadableLoaderClientWrapper.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/loader/WorkerLoaderClientBridge.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/WorkerLoaderClientBridge.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/loader/WorkerLoaderClientBridgeSyncHelper.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/WorkerLoaderClientBridgeSyncHelper.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/loader/WorkerThreadableLoader.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/WorkerThreadableLoader.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/page/EventSource.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/EventSource.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/workers/WorkerScriptLoader.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/core/workers/WorkerScriptLoader.cpp View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/xmlhttprequest/XMLHttpRequest.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M Source/core/xmlhttprequest/XMLHttpRequest.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/serviceworkers/FetchManager.cpp View 1 2 3 4 2 chunks +4 lines, -2 lines 0 comments Download
M Source/web/AssociatedURLLoader.cpp View 1 2 3 4 2 chunks +3 lines, -2 lines 0 comments Download
M public/platform/WebURLLoaderClient.h View 2 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
yhirano
PTAL This CL depends on https://codereview.chromium.org/626803002/
6 years, 2 months ago (2014-10-09 08:25:38 UTC) #2
tyoshino (SeeGerritForStatus)
lgtm
6 years, 1 month ago (2014-10-29 07:37:50 UTC) #3
yhirano
+japhet, mkwst for OWNER review.
6 years, 1 month ago (2014-10-29 08:37:47 UTC) #5
Mike West
LGTM % nits https://codereview.chromium.org/603903003/diff/60001/Source/core/fetch/RawResource.cpp File Source/core/fetch/RawResource.cpp (right): https://codereview.chromium.org/603903003/diff/60001/Source/core/fetch/RawResource.cpp#newcode102 Source/core/fetch/RawResource.cpp:102: ASSERT(count() == 1 || !handle); Can ...
6 years, 1 month ago (2014-11-04 15:09:31 UTC) #6
yhirano
https://codereview.chromium.org/603903003/diff/60001/Source/core/fetch/RawResource.cpp File Source/core/fetch/RawResource.cpp (right): https://codereview.chromium.org/603903003/diff/60001/Source/core/fetch/RawResource.cpp#newcode102 Source/core/fetch/RawResource.cpp:102: ASSERT(count() == 1 || !handle); On 2014/11/04 15:09:30, Mike ...
6 years, 1 month ago (2014-11-05 04:38:40 UTC) #7
yhirano
6 years, 1 month ago (2014-11-05 04:38:42 UTC) #8
Mike West
Still LGTM.
6 years, 1 month ago (2014-11-05 08:23:25 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/603903003/100001
6 years, 1 month ago (2014-11-06 01:15:55 UTC) #11
commit-bot: I haz the power
6 years, 1 month ago (2014-11-06 02:33:54 UTC) #12
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as 184892

Powered by Google App Engine
This is Rietveld 408576698