Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Issue 603893002: Apply automatic range checks to content enum types across IPC. (Closed)

Created:
6 years, 3 months ago by anujsharma
Modified:
6 years, 2 months ago
Reviewers:
Avi (use Gerrit), nasko
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Apply automatic range checks to content enum types across IPC. This is part of a long-running background task to remove the remaining uses of the unchecked IPC_ENUM_TRAITS() macro. BUG=246708 Committed: https://crrev.com/3cc3a684c62e2344aaa5a6a84f9300926330e4d3 Cr-Commit-Position: refs/heads/master@{#296894}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Changes made as per comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M content/common/android/gin_java_bridge_errors.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/common/gin_java_bridge_messages.h View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 10 (2 generated)
anujsharma
nasko@chromium.org: Please review changes in message change avi@chromium.org: Please review changes in content change
6 years, 3 months ago (2014-09-25 08:57:51 UTC) #2
Avi (use Gerrit)
lgtm
6 years, 2 months ago (2014-09-25 15:36:07 UTC) #3
nasko
https://codereview.chromium.org/603893002/diff/1/content/common/gin_java_bridge_messages.h File content/common/gin_java_bridge_messages.h (right): https://codereview.chromium.org/603893002/diff/1/content/common/gin_java_bridge_messages.h#newcode20 content/common/gin_java_bridge_messages.h:20: IPC_ENUM_TRAITS_MAX_VALUE(content::GinJavaBridgeError, content::kGinJavaBridgeErrorLast) Lines should not exceed 80 characters. Please ...
6 years, 2 months ago (2014-09-25 16:29:41 UTC) #4
anujsharma
@nasko, thanks for your feedback, I have incorporated changes suggested. PTAL https://codereview.chromium.org/603893002/diff/1/content/common/gin_java_bridge_messages.h File content/common/gin_java_bridge_messages.h (right): ...
6 years, 2 months ago (2014-09-26 03:20:25 UTC) #5
nasko
lgtm
6 years, 2 months ago (2014-09-26 04:41:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/603893002/20001
6 years, 2 months ago (2014-09-26 05:13:44 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001) as b0cac9c8b484f23a5db1a808ca1cdc4ddbf6da30
6 years, 2 months ago (2014-09-26 06:17:12 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-09-26 06:17:50 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3cc3a684c62e2344aaa5a6a84f9300926330e4d3
Cr-Commit-Position: refs/heads/master@{#296894}

Powered by Google App Engine
This is Rietveld 408576698