content/browser/service_worker/embedded_worker_instance.cc - Issue 603863002: SW: Move TRACE_EVENT_ASYNC_END to avoid early return and fix typo

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/embedded_worker_instance.cc

Issue 603863002: SW: Move TRACE_EVENT_ASYNC_END to avoid early return and fix typo (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/service_worker/embedded_worker_instance.cc

diff --git a/content/browser/service_worker/embedded_worker_instance.cc b/content/browser/service_worker/embedded_worker_instance.cc

index ee909a512eb0406305149e76fb27532d3be1fbb5..c22c5030d7589d0203d631a9cc53b3e3f32f0481 100644

--- a/content/browser/service_worker/embedded_worker_instance.cc

+++ b/content/browser/service_worker/embedded_worker_instance.cc

@@ -228,6 +228,10 @@ void EmbeddedWorkerInstance::ProcessAllocated(

int process_id,

ServiceWorkerStatusCode status) {

DCHECK_EQ(process_id_, -1);

+ TRACE_EVENT_ASYNC_END1("ServiceWorker",

+ "EmbeddedWorkerInstance::ProcessAllocate",

+ params.get(),

+ "Status", status);

if (status != SERVICE_WORKER_OK) {

status_ = STOPPED;

callback.Run(status);

@@ -236,10 +240,6 @@ void EmbeddedWorkerInstance::ProcessAllocated(

const int64 service_worker_version_id = params->service_worker_version_id;

process_id_ = process_id;

GURL script_url(params->script_url);

- TRACE_EVENT_ASYNC_END1("ServiceWorker",

- "EmbeddedWorkerInstance::ProcessAllocate",

- params.get(),

- "Status", status);

RegisterToWorkerDevToolsManager(

process_id,

context_.get(),

« no previous file with comments | « no previous file | content/child/service_worker/service_worker_dispatcher.cc » ('j') | content/child/service_worker/service_worker_dispatcher.cc » ('J')