Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Issue 603823002: Revert of Add test for ChromeVox keyboard commands. (Closed)

Created:
6 years, 3 months ago by jam
Modified:
6 years, 3 months ago
Reviewers:
dmazzoni, David Tseng, sky
CC:
chromium-reviews, ben+aura_chromium.org, oshima+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, yuzo+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, kalyank, sadrul, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, nkostylev+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Revert of Add test for ChromeVox keyboard commands. (patchset #21 id:390004 of https://codereview.chromium.org/490443002/) Reason for revert: flakes, see http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/31850 failures: TestAsNormalAndGuestUser/SpokenFeedbackTest.ChromeVoxPrefixKey/0 TestAsNormalAndGuestUser/SpokenFeedbackTest.ChromeVoxPrefixKey/1 TestAsNormalAndGuestUser/SpokenFeedbackTest.ChromeVoxShiftSearch/1 TestAsNormalAndGuestUser/SpokenFeedbackTest.ChromeVoxShiftSearch/0 LoggedInSpokenFeedbackTest.AddBookmark Original issue's description: > Add test for ChromeVox keyboard commands. > > This is just a couple of quick sanity checks to prevent future regressions > like the one in the linked bug. It tests both a Search+Shift shortcut and > the corresponding Prefix Key shortcut. > > Adds support for sending the meta modifier key in > aura/x11 tests. > > BUG=404470 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291547 > > Committed: https://chromium.googlesource.com/chromium/src/+/8cab2737f1cb6e6011b0946f6bef5027868602c0 > > Committed: https://crrev.com/91703961c10dfa0f452999ed7cb87945ea817362 > Cr-Commit-Position: refs/heads/master@{#293687} > > Committed: https://crrev.com/15ea141544fedaf306c94890b5be19b7c5df885a > Cr-Commit-Position: refs/heads/master@{#296074} TBR=dtseng@chromium.org,sky@chromium.org,dmazzoni@chromium.org NOTREECHECKS=true NOTRY=true BUG=404470 Committed: https://crrev.com/14e5bdf573d0621dfdd553888a5d3c557fb699a0 Cr-Commit-Position: refs/heads/master@{#296627}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -153 lines) Patch
M chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc View 9 chunks +68 lines, -143 lines 0 comments Download
M ui/aura/test/ui_controls_factory_ozone.cc View 3 chunks +2 lines, -10 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jam
Created Revert of Add test for ChromeVox keyboard commands.
6 years, 3 months ago (2014-09-25 02:10:04 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/603823002/1
6 years, 3 months ago (2014-09-25 02:11:16 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as 96ecac7e99d478c0048d644dafcf5d16bccdd3b9
6 years, 3 months ago (2014-09-25 02:12:05 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/14e5bdf573d0621dfdd553888a5d3c557fb699a0 Cr-Commit-Position: refs/heads/master@{#296627}
6 years, 3 months ago (2014-09-25 02:14:15 UTC) #4
jam
6 years, 3 months ago (2014-09-25 06:42:46 UTC) #5
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/600373002/ by jam@chromium.org.

The reason for reverting is: sorry I reverted this incorrectly, the problem was
that the isolate needed a nacl file. I'm not sure why it only needed it on debug
cros and not release. I landed it in https://codereview.chromium.org/597283004/.

Powered by Google App Engine
This is Rietveld 408576698