Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 603803002: Remove implicit HANDLE conversions from elf. (Closed)

Created:
6 years, 3 months ago by rvargas (doing something else)
Modified:
6 years, 2 months ago
Reviewers:
gab, robertshield
CC:
chromium-reviews, caitkp+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove implicit HANDLE conversions from elf. BUG=416722 R=gab@chromium.org, robertshield@chromium.org Committed: https://crrev.com/42d5525e3dbb7cd88da93e1d200fc31ae8f0b8d5 Cr-Commit-Position: refs/heads/master@{#296819}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M chrome_elf/create_file/chrome_create_file_unittest.cc View 2 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
rvargas (doing something else)
6 years, 3 months ago (2014-09-24 23:05:41 UTC) #1
gab
lgtm
6 years, 2 months ago (2014-09-25 15:50:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/603803002/1
6 years, 2 months ago (2014-09-25 19:17:49 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/13552)
6 years, 2 months ago (2014-09-25 19:28:50 UTC) #6
rvargas (doing something else)
Robert, PTAL
6 years, 2 months ago (2014-09-25 21:55:02 UTC) #8
robertshield
lgtm
6 years, 2 months ago (2014-09-25 23:03:28 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/603803002/1
6 years, 2 months ago (2014-09-25 23:04:54 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1) as 3fc61aecd6670b2271695224766b1de8af5c015a
6 years, 2 months ago (2014-09-25 23:10:58 UTC) #12
commit-bot: I haz the power
6 years, 2 months ago (2014-09-25 23:12:16 UTC) #13
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/42d5525e3dbb7cd88da93e1d200fc31ae8f0b8d5
Cr-Commit-Position: refs/heads/master@{#296819}

Powered by Google App Engine
This is Rietveld 408576698