Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 603763002: [telemetry] Fix MSR power monitor on Windows bots. (Closed)

Created:
6 years, 3 months ago by dtu
Modified:
6 years, 3 months ago
Reviewers:
tonyg
CC:
chromium-reviews, telemetry+watch_chromium.org, sullivan
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[telemetry] Fix MSR power monitor on Windows bots. I VNCed into a bot and learned that the Buildbot scripts munge the environment variables, so that PROGRAMFILES(X86) doesn't exist. Using platform.machine() is a more robust, cross-platform way of checking if the OS is 64-bit. The Windows XP bots still worked, because their OSes are all 32-bit. BUG=336556 TEST=None. Committed: https://crrev.com/3bbeaa6aa2cc762ceac9c886660af7b0db59c346 Cr-Commit-Position: refs/heads/master@{#296564}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/telemetry/telemetry/core/platform/win_platform_backend.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
dtu
6 years, 3 months ago (2014-09-24 22:02:20 UTC) #2
tonyg
lgtm
6 years, 3 months ago (2014-09-24 22:16:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/603763002/1
6 years, 3 months ago (2014-09-24 22:18:22 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 1b29260893f93e2027aab3ea72a1374b327f72bf
6 years, 3 months ago (2014-09-24 23:37:28 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-24 23:47:05 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3bbeaa6aa2cc762ceac9c886660af7b0db59c346
Cr-Commit-Position: refs/heads/master@{#296564}

Powered by Google App Engine
This is Rietveld 408576698